GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — v0.0.14-beta.1 (4/5): Every tool call keeps its own transcript row by Obed0101 · Pull Request #140 · MendCode/MendCode Conversation
|
|
MendCode: @Obed0101's MendCode worked on this pull request on one of its devices; released 2026-11-10 21:31 UTC. |
All reactions
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Obed0101
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MendCode review
No findings · nothing in this change was confirmed as a problem
head d608ea3b230f
Merge risk: 🟡 Medium · The patch changes central transcript layout and cached row accounting used by interactive chat, inline history, and previews. Regressions would primarily appear as missing rows, incorrect spacing or scrolling, or broken card interactions rather than changes to tool execution.
Change: Bug fix · Review effort: 2/5, about 15 minutes
This change removes aggregate tool-run rows in balanced and full views while retaining individual card expansion, pagination, and find behavior; no new code defects were verified within this stacked diff. Risk is medium because transcript layout and caching affect scrolling, inline history, and image placement; tests were inspected but not executed. Reader summaries covered the three tool helpers, five changed test files, and language.svg/notice.svg, with relevant code reopened for verification; no supplied file was marked not read, and SVG changes were reviewed as source rather than rendered.
Readers: 10 files went to readers instead of the review pass whole: 10 code files by gpt-6-luna (the review pass gets their summaries and the hunks of their risk spots; 2 calls, up to 3 at once, 59,066 tokens counted). Their summaries are hints, not findings. 9 code files no reader could read went to the review pass whole (the readers' share of the review's token cap is spent; the reader gave no usable answer for this file).
Stacked on #139: only this pull request's own commits since #139's head 962f644.
Walkthrough
The transcript now renders individual tool calls instead of grouping completed reads, searches, or commands into aggregate labels. The patch removes run-fold planning, run-specific interaction state, and aggregate formatters while preserving card-level controls and the existing pending-question exception. Minimal-view summarization, tool execution, protocol contracts, and persistence remain unchanged.
Changes
| Layer / files | Summary |
|---|---|
Transcript rendering apps/cli/src/view/transcript.ts, apps/cli/src/view/tool-card.ts, apps/cli/src/view/tool-frame.ts, apps/cli/src/view/tool-summary.ts |
Remove aggregate-run rendering, markers, formatters, and reveal state, and simplify layout cache keys and image visibility guards. |
Behavioral regression tests apps/cli/test/chat-transcript.test.ts, apps/cli/test/inline-mode.test.ts, apps/cli/test/tool-density.test.ts, apps/cli/test/tool-output.test.ts, apps/cli/test/turn-closing-line.test.ts |
Replace run-fold expectations with individual-call visibility checks and adapt inline history, shell ordering, and find restoration assertions. |
Density snapshots apps/cli/test/fixtures/density-golden/calm-100.txt, apps/cli/test/fixtures/density-golden/dense-100.txt, apps/cli/test/fixtures/density-golden/standard-100.txt |
Record individual read and search cards at each density instead of aggregate rows. |
Documentation and generated metadata CHANGELOG.md, docs/customize.md, docs/layout.md, packages/daemon/cards/cards.generated.json |
Document independent tool rows and retained card controls, and refresh the generated cards revision. |
README illustrations docs/assets/readme/language.svg, docs/assets/readme/notice.svg, docs/assets/readme/session.svg |
Regenerate terminal illustrations with individual Read and Grep output and reposition surrounding content. |
Pre-merge checks: ⚠️ 2 warning · ✅ 1 passed
| Check | Status | Explanation |
|---|---|---|
| Title | The title captures the main change but overstates its scope: minimal mode still summarizes calls, as explicitly asserted in apps/cli/test/chat-transcript.test.ts:433. | |
| Description | The description explains the behavior, motivation, and reported checks, but the full-suite result belongs to the top of the stack rather than this exact head. This read-only review did not independently execute tests or validate the performance claim. | |
| Out of scope | ✅ Passed | The implementation cleanup, adjusted tests and snapshots, documentation, illustrations, and generated revision are consistent with removing tool-run folding. |
Review details
- Files reviewed: 19 · 141 changed lines · estimated review effort 2/5, about 15 minutes
- Profile: normal · at most 8 inline comments
- Verification: the review pass raised no candidate findings, so no separate pass was needed
- Cost: 897,924 tokens in (788,608 from the provider's cache) · 2,423 out
- Readers: 10 files went to readers instead of the review pass whole: 10 code files by gpt-6-luna (the review pass gets their summaries and the hunks of their risk spots; 2 calls, up to 3 at once, 59,066 tokens counted). Their summaries are hints, not findings. 9 code files no reader could read went to the review pass whole (the readers' share of the review's token cap is spent; the reader gave no usable answer for this file).
- Stacked on #139: only this pull request's own commits since #139's head 962f644.
Performance (perf-attrib, base 962f644 against head d608ea3)
perf-attrib: baja: binary.bytes -16416B
base 962f6445857d9d0435c8d38a5ce78926144ac7ae (962f6445) vs cand d608ea3b230fa30b4d4bdc528a4bcb786ef25629 (d608ea3b), median of 2 faux-engine session(s) per side; flagged = beyond the noise measured on 18 base-vs-base runs (x1.5).
| metric | base | cand | diff |
|---|---|---|---|
| tui.after.fp_mb | 64 | 64.2 | +0.2 |
| tui.after.peak_mb | 73.5 | 73.5 | 0 |
| tui.ready.fp_mb | 54.5 | 54.8 | +0.3 |
| tui.ready.peak_mb | 73.5 | 73.5 | 0 |
| tui.rest.fp_mb | 61.2 | 59.9 | -1.3 |
| tui.rest.peak_mb | 73.5 | 73.5 | 0 |
| tui.after.rss_mb | 110 | 111.3 | +1.3 |
| tui.ready.rss_mb | 114.1 | 114.2 | +0.1 |
| tui.rest.rss_mb | 95.3 | 103 | +7.7 UP |
| tui.after.heap.extra_b | 7338002 | 6722490 | -615512 |
| tui.after.heap.objects | 242939 | 239729 | -3210 |
| tui.after.heap.protected | 19 | 19 | 0 |
| tui.after.heap.size_b | 25175442 | 24258154 | -917288 |
| tui.ready.heap.extra_b | 2856790 | 2895387 | +38597 |
| tui.ready.heap.objects | 217123 | 217212 | +89 |
| tui.ready.heap.protected | 18 | 18 | 0 |
| tui.ready.heap.size_b | 19278502 | 19330471 | +51969 |
| tui.rest.heap.extra_b | 3738519 | 4666564 | +928045 |
| tui.rest.heap.objects | 236040 | 238397 | +2357 |
| tui.rest.heap.protected | 18 | 18 | 0 |
| tui.rest.heap.size_b | 20946263 | 22114957 | +1168694 |
| tui.rest.js_code_b | 4895712 | 5882540 | +986828 |
| tui.rest.js_live_b | 19254786 | 19285179 | +30393 |
| tui.cpu_ms.after | 6256 | 6224 | -32 |
| tui.cpu_ms.ready | 384 | 384 | 0 |
| tui.cpu_ms.rest | 530 | 544 | +14 |
| binary.bytes | 72306944 | 72290528 | -16416 down |
| disk.bytes | 4109 | 4117 | +8 |
| disk.bytes_per_session | 2055 | 2059 | +4 |
JS object types that rose (count):
- tui.ready.heap.type.UnlinkedFunctionExecutable: 14137 -> 14153 (+16)
- tui.ready.heap.type.FunctionExecutable: 14151 -> 14166 (+15)
- tui.ready.heap.type.SymbolTable: 3406 -> 3416 (+10)
JS heap bytes by constructor that rose:
- tui.rest.ctor.native:Blob.bytes: 1741062 -> 1741200 (+138)
Modules loaded at start: 230 -> 230, 4634331 -> 4631481 bytes of chunks; chunk sizes only in cand: [1008597, 275922, 110300, 109824, 71309, 27978, 9124], only in base: [1008591, 275928, 112453, 110312, 71510, 27972, 9138] (chunk names are hashes: the list says which changed in size, not by what name)
Reference (skill, 2026-11-03, real model): footprint 64 ready / 66 after / peak 80 MB, 2.6 KB per session. This run (faux engine, whole process tree): 54.8 / 64.2 / peak 73.5 MB, 2059 B per session.
Files (19)
CHANGELOG.mdapps/cli/src/view/tool-card.tsapps/cli/src/view/tool-frame.tsapps/cli/src/view/tool-summary.tsapps/cli/src/view/transcript.tsapps/cli/test/chat-transcript.test.tsapps/cli/test/fixtures/density-golden/calm-100.txtapps/cli/test/fixtures/density-golden/dense-100.txtapps/cli/test/fixtures/density-golden/standard-100.txtapps/cli/test/inline-mode.test.tsapps/cli/test/tool-density.test.tsapps/cli/test/tool-output.test.tsapps/cli/test/turn-closing-line.test.tsdocs/assets/readme/language.svgdocs/assets/readme/notice.svgdocs/assets/readme/session.svgdocs/customize.mddocs/layout.mdpackages/daemon/cards/cards.generated.json
Comment @mendcode review to review again · @mendcode pause / resume · reply to a finding with explain, fix or learn · settings in .mendcode/review.yaml
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
All reactions
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
No reviewsUh oh!
There was an error while loading. Please reload this page.
Assignees
No one assignedLabels
Projects
Milestone
No milestoneDevelopment
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
1 participant
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.