GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Lazy load currency data by Robbie-Palmer · Pull Request #106 · MicroPyramid/forex-python

Conversation

@Robbie-Palmer

@Robbie-Palmer Robbie-Palmer commented Nov 6, 2021

Copy link
Copy Markdown
Contributor

By using the lazy loading design pattern, with a private field hidden behind a property, duplicate code is removed
And the currency.json file will not be read multiple times from disk

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Robbie-Palmer added 2 commits November 6, 2021 21:37
@Robbie-Palmer
Format converter.py
4e826b3
@Robbie-Palmer
Lazy load currency data from json file
7e0bb80 
Removing duplicate code, and preventing redundant disk reads
@abhijeet-1110
abhijeet-1110 merged commit 1f131f3 into MicroPyramid:master Dec 3, 2021
@Robbie-Palmer
Robbie-Palmer deleted the lazy-load-currency-data branch June 5, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Robbie-Palmer @abhijeet-1110
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.