GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow untyped imports · Pull Request #11889 · microsoft/TypeScript

Conversation

@ghost

@ghost Deleted user (ghost) commented Oct 27, 2016 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Fixes #11106
Replaces #11446
Made easier by #11704. No longer has to touch moduleNameResolver.ts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
GoToLoop reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Oct 27, 2016
@ghost ghost mentioned this pull request Oct 27, 2016
Allow untyped imports #11446
Closed
@ghost
ghost force-pushed the untyped_imports branch from 3534494 to c81fec6 Compare October 27, 2016 14:29
Andy Hanson
Allow untyped imports
4937d9c
@ghost
ghost force-pushed the untyped_imports branch from c81fec6 to 4937d9c Compare October 27, 2016 15:54
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Oct 27, 2016
View reviewed changes

@mhegazy Mohamed Hegazy (mhegazy) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With changes to the error message

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/compiler/diagnosticMessages.json Outdated
"category": "Error",
"code": 6143
},
"A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": {

@mhegazy Mohamed Hegazy (mhegazy) Oct 27, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about something more consistent with the rest of the the --noImplicitAny error message, e.g.: Could not find a declaration file for module '{0}'. All imports implicitly have type 'any'.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ghost Deleted user (ghost) Oct 27, 2016

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about: "Could not find a declaration file for module '{0}'. '{1}' implicitly has an 'any' type."

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhegazy Mohamed Hegazy (mhegazy) Oct 27, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread src/compiler/diagnosticMessages.json Outdated
},
"A package for '{0}' was found at '{1}', but is untyped. Because '--noImplicitAny' is enabled, this package must have a declaration.": {
"category": "Error",
"code": 6144

@mhegazy Mohamed Hegazy (mhegazy) Oct 27, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this error code in the 7000 along with the other --noImplicitAnyErrors

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Andy Hanson
Change diagnostic message
ce099e5
@ghost
ghost merged commit a143f97 into master Oct 27, 2016
@ghost
ghost deleted the untyped_imports branch October 27, 2016 18:32
@skellock Steve Kellock (skellock) mentioned this pull request Nov 13, 2016
TS2 import module not found infinitered/reactotron#212
Closed
@majodev Mario Ranftl (majodev) mentioned this pull request Jan 23, 2017
Investigate adding missing typings warning wmonk/create-react-app-typescript#10
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.