GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support for --jsxFactory option by sheetalkamat · Pull Request #12135 · microsoft/TypeScript

Conversation

@sheetalkamat

@sheetalkamat Sheetal Nandi (sheetalkamat) commented Nov 10, 2016

Copy link
Copy Markdown
Member

Fixes #9582 and #12067

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
notoriousb1t, styfle, bradleyayers, IllusionMH, marvinhagemeister, TonyPythoneer, and zackschuster reacted with thumbs up emoji
All reactions
  • 👍 7 reactions
Sheetal Nandi (sheetalkamat) added 7 commits November 9, 2016 12:23
@sheetalkamat
Add support for taking in jsxFactory option and report errors for inv…
4b8a557 
…alid combinations
@sheetalkamat
Verify that jsxFactory is either identifier or qualified name
f7bac98
@sheetalkamat
Resolve first identifier of the jsxFactory as part of type check
06affa6
@sheetalkamat
When emitting use jsx factory entity expression if provided
3d6950d
@sheetalkamat
Transpile unit test case
35e4c45
@sheetalkamat
Enabled test case for source map
c6b1bbe
@sheetalkamat
Add test cases for when jsxFactory cannot be resolved
a88c2ae
mhegazy
Mohamed Hegazy (mhegazy) reviewed Nov 10, 2016
View reviewed changes
Comment thread src/compiler/types.ts Outdated
/* @internal */
export interface TypeCheckerHost {
getCompilerOptions(): CompilerOptions;
getJsxFactoryEntity(): EntityName;

@mhegazy Mohamed Hegazy (mhegazy) Nov 10, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels odd. i would rather we parsed the jsxFactory string one more time in the checker instead.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sheetalkamat
Parse the jsxFactory again in the checker instead of using cached val…
dd7f00f 
…ue in the program
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Nov 10, 2016
View reviewed changes
@sheetalkamat
Sheetal Nandi (sheetalkamat) merged commit c458576 into master Nov 10, 2016
@sheetalkamat
Sheetal Nandi (sheetalkamat) deleted the jsxFactory branch November 10, 2016 17:50
This was referenced Nov 10, 2016
Add jsxFactory compiler option. #11267
Closed
force import #596
Closed
@mhegazy Mohamed Hegazy (mhegazy) mentioned this pull request Nov 21, 2016
Support for other JSX factories #6146
Merged
@appsforartists

Brenton Simpson (appsforartists) commented Nov 29, 2016

Copy link
Copy Markdown

Do we still need typescript@next for this? https://github.com/Microsoft/TypeScript/wiki/Roadmap says it's landed, but I'm seeing

error TS5023: Unknown compiler option 'jsxFactory'.

in 2.1.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 29, 2016

Copy link
Copy Markdown
Contributor

The roadmap says it is in typescript@next. the issues (#9582 and #12067) are marked with milestone TypeScript 2.1.3 which is not TypeScript 2.1.1 and has not shipped yet.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@appsforartists

Brenton Simpson (appsforartists) commented Nov 29, 2016

Copy link
Copy Markdown

Thanks for the clarification.

I'm not sure the roadmap makes that clear. The heading "2.1 (November 2016)" reads like those features have already shipped in 2.1.0, especially since they have little checkmarks next to them. Someone would have to scroll all the way to the bottom to realize the checkmarks are meant to connote "next" features.

Moreover, the PR linked from the Roadmap doesn't have a version label/milestone attached to it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 29, 2016

Copy link
Copy Markdown
Contributor

At the bottom of the roadmap page, there is an explanation that the checkmark means it is available in typescript@next.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 29, 2016

Copy link
Copy Markdown
Contributor

did not mean to sound pedantic. just wanted to make sure the process is clear. questions are always welcomed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@appsforartists

Brenton Simpson (appsforartists) commented Nov 29, 2016

Copy link
Copy Markdown

I saw that, but only after your first response. It never occurred to me to scroll to the bottom of the page until you said "The roadmap says it is in typescript@next".

Have you considered putting the checkbox descriptor at the top? How about making your roadmap more granular (e.g. change the Nov heading to 2.1.1: stable and have a heading above it for next)?

I don't mean to be nit picky, but I'm sure I'm not the last person who will misread the current Roadmap.
styfle and Hotell reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhegazy

Mohamed Hegazy (mhegazy) commented Nov 29, 2016

Copy link
Copy Markdown
Contributor

thanks for the tip. moved the note to the top. and will consider having better naming for milestones in the future.
Hotell reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dchest Dmitry Chestnykh (dchest) mentioned this pull request Dec 4, 2016
Inferno in tsx files infernojs/inferno#521
Closed
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sheetalkamat @appsforartists @mhegazy
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.