GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Quick fix to add missing 'this.' for property accesses by DanielRosenwasser · Pull Request #13759 · microsoft/TypeScript

Conversation

@DanielRosenwasser

@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) commented Jan 30, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Daniel Rosenwasser (DanielRosenwasser) added 4 commits November 11, 2016 01:22
@DanielRosenwasser
Added diagnostic.
39eb187
@DanielRosenwasser
Added tests for missing 'this' property accesses.
da356b0
@DanielRosenwasser
Added fix for missing 'this.' property accesses.
f2c0aa4
@DanielRosenwasser
Merge branch 'master' into fixMissingThis
57e224c
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Jan 30, 2017
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) added the Domain: LS: Quick Fixes Editor-provided fixes, often called code actions. label Jan 30, 2017
@DanielRosenwasser Daniel Rosenwasser (DanielRosenwasser) added this to the TypeScript 2.2 milestone Jan 30, 2017
mhegazy
Mohamed Hegazy (mhegazy) approved these changes Jan 30, 2017
View reviewed changes

@mhegazy Mohamed Hegazy (mhegazy) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna add the static check as well?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aozgaa

Arthur Ozga (aozgaa) commented Jan 30, 2017

Copy link
Copy Markdown
Contributor

LGTM :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Jan 30, 2017

Copy link
Copy Markdown
Member Author

Mohamed Hegazy (@mhegazy) yes, it's been on my computer for a few months now. 😄

Thanks guys!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) merged commit d38bc54 into master Jan 30, 2017
@DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser) deleted the fixMissingThis branch January 30, 2017 21:03
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@mhegazy Mohamed Hegazy (mhegazy) mhegazy approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Domain: LS: Quick Fixes Editor-provided fixes, often called code actions.

Projects

None yet

Milestone

TypeScript 2.2

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@DanielRosenwasser @aozgaa @mhegazy @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.