GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Support spread operator in call expressions by ahejlsberg · Pull Request #1931 · microsoft/TypeScript

Conversation

@ahejlsberg

@ahejlsberg Anders Hejlsberg (ahejlsberg) commented Feb 5, 2015

Copy link
Copy Markdown
Member

This PR adds support for the spread (...) operator in call expressions with down-level code generation for ES3/5. For example:

function drawText(x: number, y: number, ...strings: string[]) {
    // draw text
}

drawText(10, 20, "hello");
drawText(10, 20, "hello", "world");
var a = ["one", "two"];
drawText(10, 20, ...a);
drawText(10, 20, "zero", ...a, "three");

The function calls are emitted unchanged for ES6, but when the target is ES3 or ES5, the calls are rewritten as follows:

drawText(10, 20, "hello");
drawText(10, 20, "hello", "world");
var a = ["one", "two"];
drawText.apply(void 0, [10, 20].concat(a));
drawText.apply(void 0, [10, 20, "zero"].concat(a, ["three"]));

Type checking requires spread elements to match up with a rest parameter. Thus, in a typed function call it is not possible to use a spread element for non-rest parameters. For example:

var pos = [10, 20];
drawText(...pos, "hello", "world");  // Error
(<any>drawText)(...pos, "hello", "world");  // But ok in untyped call

A temporary variable may be injected to ensure the this argument is only evaluated once. For example:

interface Context {
    drawText(x: number, y: number, ...strings: string[]);
}

declare function getContext(): Context;

var text = ["hello", "world"];
getContext().drawText(10, 20, ...text);

This generates the code:

var text = ["hello", "world"];
(_a = getContext()).drawText.apply(_a, [10, 20].concat(text));
var _a;

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Anders Hejlsberg (ahejlsberg) added 2 commits February 4, 2015 13:39
@ahejlsberg
Support spread operator in call expressions
2494b2d
@ahejlsberg
Adding tests
bbe51cf
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Feb 5, 2015
yuit
yuit reviewed Feb 5, 2015
View reviewed changes
Comment thread tests/cases/conformance/expressions/functionCalls/callWithSpreadES6.ts

@yuit Yui (yuit) Feb 5, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class C/D can be pull out into its own test cases

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ahejlsberg
Addressing CR feedback
0819ca8
Anders Hejlsberg (ahejlsberg) added a commit that referenced this pull request Feb 10, 2015
@ahejlsberg
Merge pull request #1931 from Microsoft/spreadCall
4b92e42
Support spread operator in call expressions
@ahejlsberg
Anders Hejlsberg (ahejlsberg) merged commit 4b92e42 into master Feb 10, 2015
@ahejlsberg
Anders Hejlsberg (ahejlsberg) deleted the spreadCall branch February 10, 2015 17:25
@DickvdBrink Dick van den Brink (DickvdBrink) mentioned this pull request Mar 8, 2015
Spread arguments #238
Closed
@saschanaz Kagami Sascha Rosylight (saschanaz) mentioned this pull request Mar 16, 2015
Spread operator in 'new' expressions support for ES5? #2369
Closed
@nycdotnet Steve Ognibene (nycdotnet) mentioned this pull request Apr 16, 2015
Pass array as rest parameters by destructuring #2793
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ahejlsberg @robertpenner @yuit @JsonFreeman @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.