GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||
GeezerVison is showing github.com — Add showConfig tsc flag for debugging configs by weswigham · Pull Request #27353 · microsoft/TypeScript Conversation
Member
Fixes #15213 I happened to be in the area today, saw the issue while looking through something else, and though it'd actually be a somewhat useful utility to have.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Wesley Wigham (weswigham)
requested review from
a user,
Ryan Cavanaugh (RyanCavanaugh) and
Sheetal Nandi (sheetalkamat)
Wesley Wigham (weswigham)
force-pushed
the
show-config-compiler-flag
branch
from
164000b to
4544aa6
Compare
Member
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Interesting. Should we intentionally be ignoring this in --b mode? Should it error when invoked without tsconfig file?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
|
|
Sheetal Nandi (@sheetalkamat) I've updated this to support showing a config when there's no config file, but didn't enable it in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I tried to use this today but ran into a couple of issues. The first one's simple The second is that the PR doesn't appear to implement the feature as requested in #15213. I could be using it incorrectly, but my output only shows |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hmm, as is it contains everything less some things that are implied defaults/equivalent to their defaults. I suppose in that respect it makes more of a minimal config. But not doing that would be... Unfortunate. Because then we'd have to list every option. And there's a lot of options. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
It's true, but that's exactly what I want to see. I'm not sure how else to easily discover what those defaults actually are. I could be off base here, but it looks to me like the documentation for tsconfig.json shows the implied default, but not the resolved one. I might want to extend something that has implied default values when unset, like |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
tsc --init prints with a ton of commented out defaults and help text. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Replace unreliable octocat/Hello-World#1 test case with stable microsoft/TypeScript#27353 PR that has verified review comments. Add fallback repositories for PR resolution testing and implement proper timeout safety limits. - Use microsoft/TypeScript#27353 for PR fetch testing (stable, closed PR with comments) - Add multiple fallback repositories for PR resolution testing - Set max_pages=2 and max_comments=10 to prevent timeouts - Improve error handling to gracefully skip instead of failing - All 83 tests now pass without timeout issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Replace unreliable octocat/Hello-World#1 test case with stable microsoft/TypeScript#27353 PR that has verified review comments. Add fallback repositories for PR resolution testing and implement proper timeout safety limits. - Use microsoft/TypeScript#27353 for PR fetch testing (stable, closed PR with comments) - Add multiple fallback repositories for PR resolution testing - Set max_pages=2 and max_comments=10 to prevent timeouts - Improve error handling to gracefully skip instead of failing - All 83 tests now pass without timeout issues 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Replace unreliable test case with stable microsoft/TypeScript#27353 - Add fallback repositories and timeout safety (max_pages=2, max_comments=10) - Tighten integer validation to reject floats and prevent silent truncation - Improve exception handling specificity (ValueError, TypeError vs Exception) - Add comprehensive test coverage, achieving 100% (403/403 statements) - Add docstrings and refactor _validate_int for clarity - All 83 tests pass without timeout issues. Co-Authored-By: Claude <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.