GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — Relate source types covered by a target discriminated union by rbuckton · Pull Request #30779 · microsoft/TypeScript Conversation
|
|
TypeScript Bot (@typescript-bot) test this |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Heya Ron Buckton (@rbuckton), I've started to run the Definitely Typed test suite on this PR at 645853a. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Heya Ron Buckton (@rbuckton), I've started to run the extended test suite on this PR at 645853a. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
TypeScript Bot (@typescript-bot) perf test |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Heya Ron Buckton (@rbuckton), I've started to run the perf test suite on this PR at c712918. You can monitor the build here. It should now contribute to this PR's status checks. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Pardon the dust, tinkering with the on-demand benchmark script to not generate a massive wall of text when posting the results. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
04d985e to
8321adf
Compare
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Also #20889 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
8321adf to
332ea0a
Compare
|
Ryan Cavanaugh (@RyanCavanaugh): I've added tests and verified that this does indeed fix those issues. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Anders Hejlsberg (@ahejlsberg): Can you take a look? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I'd inline the constant instead of shouting all caps.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
332ea0a to
db7f701
Compare
db7f701 to
26fd6da
Compare
There was an error while loading. Please reload this page.
|
Hmm, why doesn't #12052 seem to link back to this issue? Oh, does locking an issue actually prevent it from getting new "@somebody mentioned this" links? That's too bad... it becomes much harder to follow up on these longstanding issues. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
error casting interface union field Union of two interfaces rejects keys that should be acceptable Wrong union type matching Unions within/without types should be hoisted/canonicalized to improve type compatibility cannot instantiate a tagged union whose discriminant property is union type
There was an error while loading. Please reload this page.