GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove experimental async functions by mhegazy · Pull Request #5231 · microsoft/TypeScript

Conversation

@mhegazy

@mhegazy Mohamed Hegazy (mhegazy) commented Oct 12, 2015

Copy link
Copy Markdown
Contributor

Now that async/await support has reached stage 3 in the TC39 proposal process, time to remove the --experimentalAsyncFunctions flag

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mohamed Hegazy (mhegazy) added 2 commits October 12, 2015 14:27
@mhegazy
Remove --experimentalAsyncFunctions
92f1b48
@mhegazy
Remove --experimentalAsyncFunctions from tests
e9bed76
@msftclas Microsoft Contribution License Agreements (msftclas) added the cla-not-required label Oct 12, 2015
@yuit

Yui (yuit) commented Oct 12, 2015

Copy link
Copy Markdown
Contributor

lgtm.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sandersn
sandersn reviewed Oct 12, 2015
View reviewed changes
Comment thread src/compiler/program.ts

@sandersn Nathan Shively-Sanders (sandersn) Oct 12, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we now have ES5 support for async functions? What happens if you target ES5 and then use an async function?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@mhegazy Mohamed Hegazy (mhegazy) Oct 12, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be another message Async functions are only available when targeting ECMAScript 6 and higher. which i have not changed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandersn

Nathan Shively-Sanders (sandersn) commented Oct 12, 2015

Copy link
Copy Markdown
Member

👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ctaggart

Cameron Taggart (ctaggart) commented Oct 12, 2015

Copy link
Copy Markdown
Contributor

I had to lookup and see what TC39 was. It is a well documented here:
http://tc39.github.io/ecmascript-asyncawait/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mohamed Hegazy (mhegazy) added a commit that referenced this pull request Oct 13, 2015
@mhegazy
Merge pull request #5231 from Microsoft/removeExperimentalAsyncFunctions
99d448a 
Remove experimental async functions
@mhegazy
Mohamed Hegazy (mhegazy) merged commit 99d448a into master Oct 13, 2015
@mhegazy
Mohamed Hegazy (mhegazy) deleted the removeExperimentalAsyncFunctions branch October 13, 2015 21:17
@dsebastien Sebastien Dubois (dsebastien) mentioned this pull request Oct 16, 2015
Proposal: Async Functions #1664
Closed
@ghost ghost mentioned this pull request Oct 24, 2015
Add --ignore-unrecognized-flags option #5393
Closed
@elhigu

Mikael Lepistö (elhigu) commented Dec 1, 2015

Copy link
Copy Markdown

https://github.com/Microsoft/TypeScript/wiki/Compiler-Options needs an update... this flag is still mentioned there without deprecation note.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dead-claudia Claudia Meadows (dead-claudia) mentioned this pull request Dec 17, 2015
What is the right way to use generic components with JSX? #3960
Closed
@dead-claudia Claudia Meadows (dead-claudia) mentioned this pull request Jan 8, 2016
Using lookahead to detect generic JSX elements? #6395
Closed
@NekR

Arthur Stolyar (NekR) commented Mar 22, 2016

Copy link
Copy Markdown

Is there a way to use async/await but still target ES5? I mean, there is many envs which do not support ES2015 100%, but they support yield. So would be good to target ES5, but still use yield and async/await.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DanielRosenwasser

Daniel Rosenwasser (DanielRosenwasser) commented Mar 22, 2016

Copy link
Copy Markdown
Member

For the time being, no. But we're working on supporting async/await in pre-ES6 targets.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@NekR

Arthur Stolyar (NekR) commented Mar 22, 2016

Copy link
Copy Markdown

Daniel Rosenwasser (@DanielRosenwasser) thanks. Just got the idea:
TS -> ES6 and then transpiling to ES5 via Babel with disabled yield transpilation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@microsoft Microsoft (microsoft) locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mhegazy @yuit @sandersn @ctaggart @elhigu @NekR @DanielRosenwasser @msftclas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.