GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix for Issue #21 - Stepping through breakpoints sometime doesn't work by AutonomicCoder · Pull Request #28 · microsoft/vscode-mono-debug

Conversation

@AutonomicCoder

@AutonomicCoder Michael Toscano (AutonomicCoder) commented Apr 13, 2017

Copy link
Copy Markdown
Contributor

These two commits provide a fix for #21. Root cause was malformed StackFrame.source

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Michael Toscano (AutonomicCoder) added 2 commits April 13, 2017 09:43
@AutonomicCoder
Add file logging to support remote attach scenerio
964905d 
Added option `—log-file=` command line option and `mono_debug_logfile` environment variable to enable logging to a file in addition to `stderr`.

Change all referenced to `Console.Error.WriteLine` to use the new `Program.Log` methods.
@AutonomicCoder
Don’t provide Source in StackFrames w/o source
4084a0b 
Modified the `StackFrame` object to ensure that it fully complies to the schema
https://github.com/Microsoft/vscode-debugadapter-node/blob/master/debugProtocol.json

Added a `Source` object factory which prevents creating invalid `Source` objects.
@borgdylan

Dylan Borg (borgdylan) commented Apr 14, 2017

Copy link
Copy Markdown

This PR is not making a big difference with the case of Xamarin apps. The debugger is even failing to connect.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AutonomicCoder

Michael Toscano (AutonomicCoder) commented Apr 14, 2017

Copy link
Copy Markdown
Contributor Author

Dylan Borg (@borgdylan) Sorry, it looks like the Xamarin issue is separate.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@borgdylan

Dylan Borg (borgdylan) commented Apr 14, 2017

Copy link
Copy Markdown

I am rebuilding my Xamarin SDK to see if anything changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@borgdylan

Dylan Borg (borgdylan) commented Apr 14, 2017

Copy link
Copy Markdown

The issues were from changes done by Xamarin. Working around those and using your patch makes debugging work! Thank you!
AutonomicCoder reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@egamma Erich Gamma (egamma) assigned Andre Weinand (weinand) Apr 16, 2017
@borgdylan

Dylan Borg (borgdylan) commented Apr 16, 2017

Copy link
Copy Markdown

Please merge this Andre Weinand (@weinand), fixes the issues I had. Is it working for you buonan xianbing (@tengxianbing) ?
buonan reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@buonan

buonan commented Apr 17, 2017

Copy link
Copy Markdown

Works great for me! I upgraded to VS Code 1.11.2, built issue#21 branch, installed the vsix and was able to debug/step through my mono project.

Thank you!
borgdylan and AutonomicCoder reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@weinand Andre Weinand (weinand) added this to the April 2017 milestone Apr 17, 2017
@weinand
Andre Weinand (weinand) merged commit f70c7d0 into microsoft:master Apr 17, 2017
@weinand

Andre Weinand (weinand) commented Apr 17, 2017

Copy link
Copy Markdown
Contributor

Thanks a lot for fixing #21.
I merged both commits but in general I suggest to submit features (e.g. logging to file) and fixes in separate PRs so that I can decide on a case by case basis what to merge and what not.

Please note that I'm already working on using the nuget package for the debug protocol (see #16). This will make some of the merged code obsolete. You can see a preview of that work in the aweinand/dap_nuget branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AutonomicCoder
Michael Toscano (AutonomicCoder) deleted the issue-21 branch April 17, 2017 15:29
@AutonomicCoder

Michael Toscano (AutonomicCoder) commented Apr 17, 2017

Copy link
Copy Markdown
Contributor Author

Andre Weinand (@weinand) - Happy to help 😄 . I completely understand regarding distinct PRs. Advice taken.

Thanks for the merge while #16 is in the works. I'll take a look at aweinand/dap_nuget as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@borgdylan

Dylan Borg (borgdylan) commented Apr 17, 2017

Copy link
Copy Markdown

Good luck Andre Weinand (@weinand) with the DAP work. This fix was a huge achievement. Here's to not having any regressions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@weinand Andre Weinand (weinand) mentioned this pull request Apr 17, 2017
Breakpoints pause the debugger but cannot step through code VS Code 1.9 and Mono 4.8 #21
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@weinand Andre Weinand (weinand)

Labels

None yet

Projects

None yet

Milestone

April 2017

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AutonomicCoder @borgdylan @buonan @weinand
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.