GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use absolute paths for system framework references by DimitarNestorov · Pull Request #1012 · MonitorControl/MonitorControl

Conversation

@DimitarNestorov

@DimitarNestorov DimitarNestorov commented Apr 21, 2022

Copy link
Copy Markdown
Contributor

This change is to improve developer experience. If you clone MonitorControl in a deep enough folder (e.g. /tmp/1/2/3/4/5/6/7) those frameworks will appear as if they are missing.

Before After
Before After

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DimitarNestorov
Use absolute paths for system framework refs
eab0fa3
@DimitarNestorov

DimitarNestorov commented Apr 21, 2022

Copy link
Copy Markdown
Contributor Author

Not sure what's up with CI. Tried running with my changes reverted but it's still failing: https://github.com/dimitarnestorov/MonitorControl/runs/6112268134?check_suite_focus=true
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the0neyouseek

the0neyouseek commented Apr 21, 2022

Copy link
Copy Markdown
Member

@DimitarNestorov It seems to be an issue with the KeyboardShortcuts package, not your changes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waydabber

waydabber commented May 6, 2022

Copy link
Copy Markdown
Member

Also SimplyCoreAudio. I think there might be some changes here that somehow adversely affects packages.

@DimitarNestorov - how should we proceed with this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waydabber

waydabber commented May 6, 2022

Copy link
Copy Markdown
Member

Ok, disragard that. It seems everything fails now with the CI build as the other PR got stuck with the exact same issue #1025
DimitarNestorov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waydabber waydabber added the Type: Enhancement label May 6, 2022
waydabber
waydabber approved these changes May 6, 2022
View reviewed changes

@waydabber waydabber left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, I'll approve this one as the changes are entirely sensible, I don't know whats up with the CI build.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DimitarNestorov reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@waydabber
waydabber merged commit 252a718 into MonitorControl:main May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waydabber waydabber waydabber approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DimitarNestorov @the0neyouseek @waydabber
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.