GeezerVison

Problem

The menu could show displays that should have been left out:

• With the "hide Apple displays" preference enabled, Apple displays still appeared in the menu.
• The built-in display showed up and was controlled by the app even when it was not set to be controlled.

Cause

MenuHandler builds a filtered list of displays, then calls DisplayManager.sortDisplaysByFriendlyName(). That function ignored the list and sorted DisplayManager.displays, which holds every display. Assigning the result back to displays replaced the filtered list with the full one, so the filtering had no effect.

Fix

sortDisplaysByFriendlyName now takes the displays to sort as a parameter, and MenuHandler passes in its filtered list. The sort order is unchanged.

Testing

Tested locally:

• Apple displays are hidden from the menu when the preference is on.
• The built-in display is no longer controlled when it isn't set to be.
• Menu order is unchanged.