GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add check for M1 Pro/Max Macbook Pro HDMI by the0neyouseek · Pull Request #904 · MonitorControl/MonitorControl

Conversation

@the0neyouseek

@the0neyouseek the0neyouseek commented Jan 22, 2022

Copy link
Copy Markdown
Member

As with the Mac mini, the new Macbook Pro (M1 Pro/Max, 14" and 16") models of 2021 seems to have DDC communication blocked on their HDMI port.

This PR add a check for these models. (And an easy way to add newer models if needed)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the0neyouseek
feat: Add check for M1 Pro/Max Macbook Pro HDMI
f2b72d7
@the0neyouseek the0neyouseek added Type: Enhancement labels Jan 22, 2022
@the0neyouseek
the0neyouseek requested a review from waydabber January 22, 2022 12:22
@JoniVR

JoniVR commented Jan 22, 2022

Copy link
Copy Markdown
Member

LGTM!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JoniVR
JoniVR approved these changes Jan 22, 2022
View reviewed changes
@the0neyouseek
the0neyouseek merged commit 370d6cf into main Jan 22, 2022
@the0neyouseek
the0neyouseek deleted the feat/mbp-check branch January 22, 2022 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoniVR JoniVR JoniVR approved these changes
@waydabber waydabber Awaiting requested review from waydabber

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@the0neyouseek @JoniVR
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.