GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Onboarding Screen by the0neyouseek · Pull Request #906 · MonitorControl/MonitorControl

Conversation

@the0neyouseek

@the0neyouseek the0neyouseek commented Jan 22, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR is related to this issue: #676

What's new

  • ✨ Add an onboarding screen (only appear on first launch)
  • 🇫🇷 French translations for the new onboarding screen
  • 🛠 Reorganize AppDelegate a bit
  • 🛠 Move View Controllers into folders

Tests

I've tested the onboarding screen on both small and large screen, HiDPI and normal res, light and dark mode.

If you want to test the PR you can save your preferences located here:

~/Library/Preferences/me.guillaumeb.MonitorControl.plist

and run this command to reset your current preferences (where the app check to know if it was started once)

$ defaults delete me.guillaumeb.MonitorControl

before the launching the project in XCode.

What's left to do

All current translations beside French & English (for the new onboarding) are missing for now.
If you want to help with translations, please read the opening post of this discussion: #637

  • Translations :
    • Spanish
    • German
    • Hungarian
    • Italian
    • Korean
    • Dutch
    • Portuguese (Brazil)
    • Turkish
    • Chinese, Simplified
    • Chinese, Traditional (Taïwan)
  • I also forgot to translate the keyboard screenshot part (I'll get to it asap)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the0neyouseek
feat: Onboarding Screen
de80229 
- Add an onboarding screen (only appear on first launch)
- 🇫🇷 French translations for the new onboarding screen
- Reorganize AppDelegate a bit
- Move View Controllers into folders
@the0neyouseek the0neyouseek added Type: Enhancement in progress Issue currently being worked on labels Jan 22, 2022
@the0neyouseek
the0neyouseek requested review from JoniVR and waydabber January 22, 2022 22:06
waydabber
waydabber previously approved these changes Jan 23, 2022
View reviewed changes

@waydabber waydabber left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good! Good job!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the0neyouseek
feat: Open Menu on "Start using MonitorControl"
2c69064
@the0neyouseek
the0neyouseek dismissed waydabber’s stale review via 2c69064 January 23, 2022 09:06
@the0neyouseek
i18n: Translate keyboard screenshot hint
645dc47
@the0neyouseek

the0neyouseek commented Jan 23, 2022

Copy link
Copy Markdown
Member Author

I think i'm done with this PR, feel free to add commits if you want to maybe add some translations @waydabber @JoniVR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the0neyouseek
Merge branch 'main' into feat/onboarding
4984e01
@waydabber

waydabber commented Jan 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

He @the0neyouseek - I have an issue - something seems to be off.

Screen Shot 2022-01-23 at 16 58 46

Steps to reproduce:

  • delete app defaults defaults delete me.guillaumeb.MonitorControl
  • pull the latest code from feat/onboarding
  • build&run

Also, besides the unexpected nil, the onboarding screen does not pop up now (it did pop up when I did the last approve as I tested it - so something must have changed since then) and a complaint about permissions do pop up (when security permissions are not granted to the app) - I thought this should not present itself before the onboarding so it is not the first impression.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the0neyouseek

the0neyouseek commented Jan 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

That's weird. Maybe I messed something up, I'll look into it.
Edit: Yup, it's me, I messed up the merge…
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the0neyouseek
bug: Fix AppDelegate
000beb5
@the0neyouseek the0neyouseek added done Work on this issue is complete. Will be available on next release in progress Issue currently being worked on and removed in progress Issue currently being worked on labels Jan 23, 2022
@the0neyouseek
the0neyouseek requested a review from waydabber January 23, 2022 18:01
waydabber
waydabber approved these changes Jan 24, 2022
View reviewed changes

@waydabber waydabber left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works perfectly now! :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@waydabber

waydabber commented Jan 26, 2022

Copy link
Copy Markdown
Member

Hey @the0neyouseek - is this PR now done or you still working on it? Shouldn't it be merged? :)
the0neyouseek reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the0neyouseek

the0neyouseek commented Jan 26, 2022

Copy link
Copy Markdown
Member Author

Done for me :) You can merge it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@waydabber
waydabber merged commit e60ffc9 into main Jan 26, 2022
@waydabber
waydabber deleted the feat/onboarding branch January 26, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waydabber waydabber waydabber approved these changes
@JoniVR JoniVR Awaiting requested review from JoniVR

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

done Work on this issue is complete. Will be available on next release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@the0neyouseek @waydabber
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.