GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fixed worldcat by TimHenkelmann · Pull Request #91 · MusicConnectionMachine/StructuredData

This repository was archived by the owner on Apr 12, 2019. It is now read-only.

Conversation

@TimHenkelmann

@TimHenkelmann TimHenkelmann commented May 4, 2017

Copy link
Copy Markdown
Contributor

Worldcat only displays the first 5000 entries (https://www.worldcat.org/search?q=dt%3Asco&fq=yr%3A1800&dblist=638&start=4991 gives the same results as https://www.worldcat.org/search?q=dt%3Asco&fq=yr%3A1800&dblist=638&start=10000). This resulted in tons of duplicates, therefore a hard limit of 5000 entries was implemented.
... sorry @kordianbruck you should not have trusted me! ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TimHenkelmann
fixed worldcat script as only the first 5000 entries are shown
e132f9a
kordianbruck
kordianbruck suggested changes May 4, 2017
View reviewed changes
Comment thread WorldCat/worldcat.js
if (linkCounter > total_links) {
// worldcat only shows the first 5000 pages
console.log(linkCounter)
if (linkCounter == 500) {

@kordianbruck kordianbruck May 4, 2017

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theres a 0 missing here no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@TimHenkelmann TimHenkelmann May 5, 2017

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that's right as we get 10 entries per link, so thats 500*10=5000 in total.
But I just removed an unnecessary comment from the cli.js that is no longer needed (because earlier the script ran out of RAM )

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@TimHenkelmann
removed unnecessary comment
cd75978
kordianbruck
kordianbruck approved these changes Jun 2, 2017
View reviewed changes
@kordianbruck

kordianbruck commented Jun 2, 2017

Copy link
Copy Markdown
Contributor

@TimHenkelmann can we still merge this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@kordianbruck kordianbruck kordianbruck approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@TimHenkelmann @kordianbruck
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.