GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(core): structural pseudo-classes and :root by triniwiz · Pull Request #11531 · NativeScript/NativeScript

Conversation

@triniwiz

@triniwiz triniwiz commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Checklist

  • The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • You have signed the CLA.
  • All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
  • Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

:first-child, :last-child, :nth-child(), :root and the other structural pseudo-classes are treated as states a view reports, like :active, and no view ever reports them, so they never match. CSS frameworks rely on them heavily: Bootstrap uses :first-child/:last-child about 300 times (the ends of list groups, button and input groups, cards), Tailwind's first:, last:, odd: and even: variants compile to them, and both declare their custom properties on :root.

What is the new behavior?

  • :first-child, :last-child, :only-child, :nth-child(an+b), :nth-last-child(an+b) and the -of-type forms match from the view's position among its parent's children, using the parent's getChildIndex/getChildAt/getChildrenCount as the sibling combinators do. odd, even, 3, 2n+1, -n+3 are supported; :nth-child(an+b of S) is not and drops the selector.
  • A layout re-matches the siblings a change can affect. Selectors that look back are flagged like + and ~ (so the existing insertChild/removeChild invalidation covers them). Selectors that look forward (:last-child, :nth-last-child(), :last-of-type) get matching flags (hasNextSiblingSelectors, hasFollowingSiblingSelectors), and addChild/insertChild/removeChild re-match the views before the change. Scopes without such selectors do no extra work.
  • :root matches the application's root view and each modal's root view (the views core gives the ns-root and ns-modal classes), with the specificity of a pseudo-class.

Tests: css-structural-pseudo.spec.ts (10: matching, formulas, combinations with :not()/:is(), dependency flags, and re-matching on append/insert/remove in a StackLayout) and :root cases in css-selector.spec.ts.

Verified with all of these core PRs merged together (#11527–#11537): apps/automated passes on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependent IMAGE-CACHE.test_ImageCache_ValidUrl timeout, which also passes on reruns).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
triniwiz added 2 commits October 15, 2026 08:10
@triniwiz
feat(core): structural pseudo-classes
0285352
`:first-child`, `:last-child`, `:only-child`, `:nth-child()`,
`:nth-last-child()` and the `-of-type` forms now match from a view's
position among its parent's children. They were treated as states a
view reports, like `:active`, and no view ever reported them, so CSS
frameworks' rules for the ends of lists, button groups and cards (and
Tailwind's `first:`/`last:`/`odd:` variants) never applied.

Matching reuses the parent's getChildIndex/getChildAt/getChildrenCount,
as the sibling combinators do, and a layout re-matches the siblings a
change can affect: selectors that look back are flagged like `+` and
`~`, and the ones that look forward (`:last-child`,
`:nth-last-child()`) get the same treatment for the views before an
added or removed child. `:nth-child(an+b of S)` is not supported.
@triniwiz
feat(core): :root selector
7d801f8
`:root` matches the application's root view and each modal's root view
(the views core gives the `ns-root` and `ns-modal` classes), with the
specificity of a pseudo-class. CSS frameworks declare their custom
properties and base styles on `:root`; core used to treat it as a state
no view reported, so none of them applied.
@nx-cloud

nx-cloud Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 0d88e51

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 2m 56s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-15 20:40:06 UTC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11531
npm i https://pkg.pr.new/@nativescript/vite@11531
npm i https://pkg.pr.new/@nativescript/webpack@11531

commit: 0d88e51

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@edusperoni

edusperoni commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

The main reason these were never implemented is because of performance and walking the tree. I'd hold off on this until we improve our CSS engine

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@triniwiz
chore(core): drop comments
0d88e51

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@triniwiz @edusperoni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.