GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat(core): CSS Color 4 and 5 color functions by triniwiz · Pull Request #11532 · NativeScript/NativeScript

Conversation

@triniwiz

@triniwiz triniwiz commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Checklist

  • The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • You have signed the CLA.
  • All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
  • Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

  • Color throws "Invalid color" for oklch(), oklab(), lab(), lch(), hwb(), color() and relative colors (oklch(from var(--x) calc(l * .9) c h)). Tailwind v4 and Bootstrap 6 define their whole palettes in oklch().
  • The fast path misreads the modern rgb()/hsl() syntax: a percentage alpha (rgb(0 0 0 / 15%) comes out opaque), rgb percentages, and none.
  • The value parser behind background and gradient stops only recognises rgb/hsl/hsv without nested functions.

What is the new behavior?

  • Those functions are parsed with @csstools/css-color-parser, which core already uses for color-mix(). The legacy rgb()/hsl()/hex/name forms keep the existing fast path.
  • parseCssColor recognises the new functions, and nested ones such as color-mix(in srgb, rgb(0 0 0), red), by matching parentheses.
  • Color.isValid() accepts the new functions and color-mix().

Tests: color/color.spec.ts (6) and new cases in css/parser.spec.ts.

Verified with all of these core PRs merged together (#11527–#11537): apps/automated passes on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependent IMAGE-CACHE.test_ImageCache_ValidUrl timeout, which also passes on reruns).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nx-cloud

nx-cloud Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 5e76050

Command Status Duration Result
nx test apps-automated -c=ios ✅ Succeeded 3m 22s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded 1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-10-29 17:30:41 UTC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11532

npm i https://pkg.pr.new/@nativescript/vite@11532

npm i https://pkg.pr.new/@nativescript/webpack@11532

commit: 5e76050
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@triniwiz
feat(core): CSS Color 4 and 5 color functions
c82a72b 
Color reads `oklch()`, `oklab()`, `lab()`, `lch()`, `hwb()`,
`color()` and relative colors (`oklch(from var(--x) calc(l * .9) c h)`)
with @csstools/css-color-parser, which core already uses for
`color-mix()`. Tailwind v4 and Bootstrap 6 define their whole palettes in
oklch, which threw "Invalid color".

The modern `rgb()`/`hsl()` syntax the fast path misread now goes the
same way: a `/` alpha given as a percentage (`rgb(0 0 0 / 15%)` came
out opaque), rgb percentages, and `none`. The legacy syntax keeps the
fast path.

The value parser behind `background` and gradients recognises the new
functions too, and nested ones such as `color-mix(in srgb, rgb(0 0 0), red)`.
`Color.isValid()` accepts them.
@triniwiz
triniwiz force-pushed the feat/css-color-functions branch from 0d6afca to c82a72b Compare October 15, 2026 13:38
triniwiz and others added 3 commits October 15, 2026 16:26
@triniwiz
chore(core): drop comments
6bf661c
@NathanWalker
Merge remote-tracking branch 'origin/main' into pr-11532
fa4764d 
# Conflicts:
#	packages/core/color/color-utils.ts
@NathanWalker
fix(core): reject unparseable color functions now that argbFromColorM…
5e76050 
…ix returns null
@NathanWalker
NathanWalker merged commit 005970f into main Oct 29, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@NathanWalker
NathanWalker deleted the feat/css-color-functions branch October 29, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@triniwiz @NathanWalker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.