GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(core): resolve var() in css animations and keyframes per view by triniwiz · Pull Request #11534 · NativeScript/NativeScript

Conversation

@triniwiz

@triniwiz triniwiz commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Checklist

  • The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • You have signed the CLA.
  • All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
  • Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

  • Animations are built once per rule from its raw declarations, before any variable is resolved, so animation: var(--animate-spin) (how Tailwind's animate-* utilities are written) and animation-duration: var(--speed) never play.
  • A var() inside @keyframes fails to convert, and the exception stops the rest of the stylesheet from being applied.

What is the new behavior?

  • A rule whose animation declarations use variables is resolved against each view when its animations play. Rules without variables are still parsed once.
  • Keyframes whose values use variables are kept unparsed and resolved against each view when they play. Other keyframes are still parsed once.
  • Keyframes that cannot be converted are skipped with a trace warning instead of throwing.

Tests: ui/styling/css-animation-variables.spec.ts (5); four fail without the change.

Verified with all of these core PRs merged together (#11527–#11537): apps/automated passes on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependent IMAGE-CACHE.test_ImageCache_ValidUrl timeout, which also passes on reruns).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nx-cloud

nx-cloud Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit c6b7b73

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 13s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗

☁️ Nx Cloud last updated this comment at 2026-10-15 20:41:03 UTC
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11534

npm i https://pkg.pr.new/@nativescript/vite@11534

npm i https://pkg.pr.new/@nativescript/webpack@11534

commit: c6b7b73
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@triniwiz
fix(core): resolve var() in css animations and keyframes per view
be09a7d 
Animations were built once per rule from its raw declarations, before
any variable was resolved, so `animation: var(--animate-spin)` (how
Tailwind's `animate-*` utilities are written) and
`animation-duration: var(--speed)` never played. A `var()` inside
`@keyframes` failed to convert and the exception stopped the rest of
the stylesheet being applied.

A rule whose animation declarations use variables, and keyframes whose
values use them, are now resolved against each view when its
animations play. Everything else is still parsed once. Keyframes that
cannot be converted are skipped with a trace warning instead of
throwing.
@triniwiz
triniwiz force-pushed the fix/css-animation-variables branch from 20397b6 to be09a7d Compare October 15, 2026 13:16
@triniwiz
chore(core): drop comments
c6b7b73
@NathanWalker
NathanWalker merged commit 2c7f149 into main Oct 29, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@NathanWalker
NathanWalker deleted the fix/css-animation-variables branch October 29, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@triniwiz @NathanWalker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.