GeezerVison is showing github.com — fix(core): keep a gesture's recognizer when its listener is swapped by triniwiz · Pull Request #11535 · NativeScript/NativeScript
Conversation
triniwiz
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Checklist
What is the current behavior?
Renderers such as React and DOMiNATIVE swap an event handler by removing the old listener and adding the new one, which for an inline arrow function happens on every render, often in response to the gesture itself. Each gesture listener owns its own GesturesObserver, so removing it tears down the native recognizer (the UIGestureRecognizer on iOS, the gesture detector on Android), and adding the new one creates a recognizer that never saw the touch in progress. A handler that sets state on down gets no move or up after it, so sliders and charts only ever see the first event. Pan, pinch and the other gestures lose the gesture the same way.
What is the new behavior?
- Removing a gesture listener stops calling it at once, but keeps its observer and native recognizer until the next turn.
- A listener for the same gesture added before then takes over that observer (
GesturesObserverBase._setCallback, internal) instead of creating a new one, so it receives the rest of the gesture.
- Observers that are not taken over are disconnected in the next turn, as before.
getGestureObservers() reflects a removal immediately.
- On iOS,
UIGestureRecognizerImpl.recognize() calls the owner's current callback with the owner's current context.
Tests: ui/core/view/gesture-observers.spec.ts (6): the recognizer is kept across a swap, the new listener receives the in-progress gesture with the right this, a removed listener is silent immediately, an unused recognizer is removed in the next turn, observers are not reused across gesture types. apps/automated gains test_swapping_touch_listener_keeps_native_recognizer (iOS) and test_swapping_gesture_listener_reuses_observer.
Verified with all of these core PRs merged together (#11527–#11537): apps/automated passes on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependent IMAGE-CACHE.test_ImageCache_ValidUrl timeout, which also passes on reruns).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nx-cloud
Bot
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
🤖 Nx Cloud AI Fix Eligible
An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.
To disable these notifications, a workspace admin can disable them in workspace settings.
View your CI Pipeline Execution ↗ for commit db9d663
| Command |
Status |
Duration |
Result |
nx test apps-automated -c=android |
❌ Failed |
20m 27s |
View ↗ |
nx run-many --target=test --configuration=ci --... |
✅ Succeeded |
<1s |
View ↗ |
💡 Dealing with memory or CPU issues? See memory and CPU details with the resource usage add-on ↗.
☁️ Nx Cloud last updated this comment at 2026-10-15 21:02:26 UTC
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pkg-pr-new
Bot
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Open in StackBlitz
npm i https://pkg.pr.new/@nativescript/core@11535
npm i https://pkg.pr.new/@nativescript/vite@11535
npm i https://pkg.pr.new/@nativescript/webpack@11535
commit: db9d663
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Renderers such as React and DOMiNATIVE swap an event handler by removing
the old listener and adding the new one, which for an inline arrow happens
on every render, often in response to the gesture itself. Each gesture
listener owned its own GesturesObserver, so removing it tore down the
native recognizer (the UIGestureRecognizer on iOS, the gesture detector on
Android) and adding the new one created a fresh recognizer that had never
seen the touch in progress. A handler that set state on `down` got no
`move` or `up` after it, so sliders and charts only ever saw the first
event; pan, pinch and the other detectors lost the gesture the same way.
Removing a gesture listener now stops calling it at once but keeps its
observer, and the native recognizer, until the next turn. A listener for
the same gesture added before then takes over that observer instead of
creating a new one, so it receives the rest of the gesture. Observers that
are not taken over are disconnected in the next turn as before.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|