GeezerVison is showing github.com — fix(core): make background: none clear the background color by triniwiz · Pull Request #11536 · NativeScript/NativeScript
Conversation
triniwiz
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Checklist
What is the current behavior?
background: none changes nothing: the background parser does not accept the none keyword, so the shorthand fails to expand and none of the background longhands change. A native control such as a button keeps its own background (e.g. Bootstrap's .nav-link pills, or any CSS reset that clears button backgrounds).
What is the new behavior?
- The background parser reads
none as the image component.
- The
background shorthand maps it to no image and, unless the declaration also gives a color, to a transparent background-color, the initial value CSS resets it to.
- Shorthands that only give an image, repeat or position still leave
background-color unset, so views keep their native default background behind an image (e.g. the iOS Page's white).
Tests: 3 parser cases in css/parser.spec.ts and 4 specs in ui/styling/style-properties.spec.ts. apps/automated gains test_setting_background_none_from_CSS_makes_backgroundColor_transparent.
Verified with all of these core PRs merged together (#11527–#11537): apps/automated passes on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependent IMAGE-CACHE.test_ImageCache_ValidUrl timeout, which also passes on reruns).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nx-cloud
Bot
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
View your CI Pipeline Execution ↗ for commit d1f2985
| Command |
Status |
Duration |
Result |
nx run-many -t build -p core,webpack5,vite |
✅ Succeeded |
23s |
View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-10-15 20:37:00 UTC
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pkg-pr-new
Bot
commented
Oct 15, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Open in StackBlitz
npm i https://pkg.pr.new/@nativescript/core@11536
npm i https://pkg.pr.new/@nativescript/vite@11536
npm i https://pkg.pr.new/@nativescript/webpack@11536
commit: d1f2985
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
`background: none` left background-color unset, so a native control such
as a button kept its own background. The shorthand parser did not accept
the `none` keyword at all, so the declaration failed to expand and none of
the background longhands changed.
The background parser now reads `none` as the image component, and the
`background` shorthand maps it to no image and, unless the declaration
also gives a color, to a transparent background-color, the initial value
CSS resets it to. Shorthands that only give an image, repeat or position
still leave background-color unset, so views keep their native default
background behind an image.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|