GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(core): make background: none clear the background color by triniwiz · Pull Request #11536 · NativeScript/NativeScript

Conversation

@triniwiz

@triniwiz triniwiz commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PR Checklist

  • The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • You have signed the CLA.
  • All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#running-unit-tests-application.
  • Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

background: none changes nothing: the background parser does not accept the none keyword, so the shorthand fails to expand and none of the background longhands change. A native control such as a button keeps its own background (e.g. Bootstrap's .nav-link pills, or any CSS reset that clears button backgrounds).

What is the new behavior?

  • The background parser reads none as the image component.
  • The background shorthand maps it to no image and, unless the declaration also gives a color, to a transparent background-color, the initial value CSS resets it to.
  • Shorthands that only give an image, repeat or position still leave background-color unset, so views keep their native default background behind an image (e.g. the iOS Page's white).

Tests: 3 parser cases in css/parser.spec.ts and 4 specs in ui/styling/style-properties.spec.ts. apps/automated gains test_setting_background_none_from_CSS_makes_backgroundColor_transparent.

Verified with all of these core PRs merged together (#11527–#11537): apps/automated passes on the iOS 26.4 simulator (1830 OK, 0 failed) and on an Android API 36 emulator (1692 OK; the one failure is the network-dependent IMAGE-CACHE.test_ImageCache_ValidUrl timeout, which also passes on reruns).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nx-cloud

nx-cloud Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d1f2985

Command Status Duration Result
nx run-many -t build -p core,webpack5,vite ✅ Succeeded 23s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-15 20:37:00 UTC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkg-pr-new

pkg-pr-new Bot commented Oct 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11536
npm i https://pkg.pr.new/@nativescript/vite@11536
npm i https://pkg.pr.new/@nativescript/webpack@11536

commit: d1f2985

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@triniwiz
fix(core): make background: none clear the background color
cda7bbf
`background: none` left background-color unset, so a native control such
as a button kept its own background. The shorthand parser did not accept
the `none` keyword at all, so the declaration failed to expand and none of
the background longhands changed.

The background parser now reads `none` as the image component, and the
`background` shorthand maps it to no image and, unless the declaration
also gives a color, to a transparent background-color, the initial value
CSS resets it to. Shorthands that only give an image, repeat or position
still leave background-color unset, so views keep their native default
background behind an image.
@triniwiz
triniwiz force-pushed the fix/background-none branch from fce6c07 to cda7bbf Compare October 15, 2026 13:17
@triniwiz
chore(core): drop comments
d1f2985
NathanWalker
NathanWalker approved these changes Oct 23, 2026
View reviewed changes
@triniwiz
triniwiz merged commit 67bf7ee into main Oct 24, 2026
9 of 10 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@triniwiz
triniwiz deleted the fix/background-none branch October 24, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NathanWalker NathanWalker NathanWalker approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@triniwiz @NathanWalker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.