GeezerVison is showing github.com — fix(vite): preserve Vue plugin imports and canonical runtime bridge by rafaelaugustos · Pull Request #11555 · NativeScript/NativeScript
Conversation
PR Checklist
- The PR title follows the contribution guidelines.
- There is an issue for the bug/feature this PR is for.
- You have signed the CLA.
- All existing tests are passing (five existing environment-dependent failures reproduced on the unchanged base; details below).
- Tests for the changes are included.
What is the current behavior?
Vue HMR rewrites dependencies whose names merely start with vue to /ns/rt, losing their exports. A per-module-served native plugin importing $navigateTo and ref from nativescript-vue can also receive duplicate helper bindings and the obsolete /ns/m/@nativescript/vendor.mjs URL.
What is the new behavior?
Match Vue runtime package boundaries and send the Vue strategy's framework imports directly to /ns/rt. Unrelated package imports retain their original destination, and the complete device transformation pipeline produces valid JavaScript for native navigation helpers.
Fixes #11554. Related to #11421; this does not claim to fix every dependency-routing case in that report.
Validation
- Five regression cases failed before the patch. Nine regression cases now pass, including positive runtime prebundle cases and similarly named bare plugin imports.
nx run vite:test: 1,842 passed, five failed. All five failures are in typescript-optional.spec.ts, reporting The "paths[1]" argument must be of type string. Received undefined. Running that spec with both changed implementation files restored to base 3224f1b reproduces the same five failures (two passing).
nx format:write on changed files; git diff --check passes.
- Original import failures observed on Android API 36 with published
@nativescript/vite 8.0.19. The patch is verified through transformation tests, not a patched native package installation. Full file-routing native HMR remains separately blocked by the SFC assembler bypassing compile-time macro transforms. Bundled --no-hmr navigation is successful on iOS and Android with stock dependencies.
Manual follow-up: serve a linked plugin importing NativeScript-Vue navigation helpers through HTTP, then verify startup and a native push. Also verify an unrelated vue-* dependency keeps its own exports after optimization.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Oct 19, 2026
nx-cloud
Bot
commented
Oct 21, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
View your CI Pipeline Execution ↗ for commit 64d385d
| Command |
Status |
Duration |
Result |
nx test apps-automated -c=android |
✅ Succeeded |
3m 35s |
View ↗ |
nx run-many --target=test --configuration=ci --... |
✅ Succeeded |
<1s |
View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-10-21 18:36:42 UTC
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Open in StackBlitz
npm i https://pkg.pr.new/@nativescript/core@11555
npm i https://pkg.pr.new/@nativescript/vite@11555
npm i https://pkg.pr.new/@nativescript/webpack@11555
commit: 64d385d
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.