GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(vite): resolve Solid runtime dev builds from package exports by NathanWalker · Pull Request #11628 · NativeScript/NativeScript

Conversation

@NathanWalker

@NathanWalker NathanWalker commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

PR Checklist

  • The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • You have signed the CLA.
  • All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing.
  • Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

With solid-js / @solidjs/* 2.0.0-rc.19, an HMR dev session fails at boot:

[ns-entry] deterministic dev session bootstrap failed TypeError: Cannot read properties of undefined (reading 'guideUrl')
    at installConsoleFooter (http://…/ns/m/node_modules/solid-js/dist/solid.dev.js:1725:26)

Two causes, both from Solid's rc.19 package layout:

  1. @solidjs/signals resolves to its prod build. The deps bundle, its root-URL shims, and the bare-import rewrite all resolve packages without the development condition, so @solidjs/signals lands on dist/prod/index.js, where DEV is undefined. rc.19's solid.dev.js reads DEV.guideUrl at module load. (rc.0 also paired with prod signals, but nothing read DEV at load.)
  2. solid-js/dist/dev.js no longer exists. The canonical solid-js URL is hard-coded in rewrite-imports, the deps bundle (seed + routing), the Solid strategy's import map, and configuration/solid.ts. rc.19 renamed the file to dist/solid.dev.js, so these URLs 404, and they diverge from the solid.dev.js URL other importers reach, which would load a second Solid instance.

What is the new behavior?

helpers/solid-runtime.ts resolves the dev build of each Solid runtime package root (solid-js, @solidjs/signals, @solidjs/universal, @solidjs/web) from that package's own exports map, preferring targets under development. All Solid pin sites use it:

  • rewrite-imports: bare runtime roots rewrite to /ns/m/node_modules/<pkg>/<dev entry>.
  • deps-bundle: the routing plugin, the vendor seed, recorded boot paths (an old recording containing /ns/m/node_modules/@solidjs/signals no longer bundles prod), and package-root URL → shim lookup all go through one resolveDepsSpecToFile.
  • Solid strategy importMapEntries: solid-js maps to the resolved dev URL.
  • configuration/solid.ts: in dev, aliases the runtime packages to their dev builds. Aliases are now anchored, so subpaths like solid-js/internal reach the exports map instead of being prefix-matched to …/dist/dev.js/internal.

Compatibility:

  • solid-js 1.x and 2.0.0-rc.0 still resolve to dist/dev.js. The exports maps of all three layouts are covered in solid-runtime.spec.ts.
  • When the exports map names no dev build, solid-js falls back to the legacy dist/dev.js.
  • The development condition is intentionally not enabled globally (see the conditions note in hmr/shared/vendor/manifest.ts about isServer stubs). Other flavors and non-Solid packages are unchanged.

Verified against an rc.19 app:

  • The deps bundle registers only solid.dev.js, signals/dist/dev.js, universal.dev.js and solid-js/dist/internal.js, with no prod Solid files.
  • /ns/m/node_modules/{solid-js,@solidjs/signals,@solidjs/universal} serve shims of those dev builds.
  • The import map's solid-js points at dist/solid.dev.js, and app modules import the same URL. This holds with and without app-level Solid aliases.
  • The full packages/vite suite passes (166 files / 1943 tests), and the new deps-bundle test fails on main.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@NathanWalker
fix(vite): resolve Solid runtime dev builds from package exports
4b207d7
Solid 2.0.0-rc.19 moved solid-js's dev build from dist/dev.js to
dist/solid.dev.js and made it read DEV from @solidjs/signals at module
load. The HMR pipeline hard-coded dist/dev.js (now a 404) and resolved
@solidjs/signals without the development condition, so solid.dev.js
paired with the signals prod build and threw reading DEV.guideUrl.

Resolve the dev entry of solid-js, @solidjs/signals, @solidjs/universal
and @solidjs/web from each package's exports map and pin bare imports,
recorded boot paths, package-root URLs, the import map and the dev
aliases to it. Solid 1.x and 2.0 rc.0 keep resolving to dist/dev.js;
other flavors and packages are untouched.
@nx-cloud

nx-cloud Bot commented Nov 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 4b207d7

Command Status Duration Result
nx test apps-automated -c=android ✅ Succeeded 3m 13s View ↗
nx run-many --target=test --configuration=ci --... ✅ Succeeded <1s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-11-09 22:21:32 UTC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkg-pr-new

pkg-pr-new Bot commented Nov 9, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11628
npm i https://pkg.pr.new/@nativescript/vite@11628
npm i https://pkg.pr.new/@nativescript/webpack@11628

commit: 4b207d7

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@NathanWalker
NathanWalker merged commit 17f6206 into main Nov 9, 2026
10 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@NathanWalker
NathanWalker deleted the fix/vite-solid-dev-entry branch November 9, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@NathanWalker
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.