GeezerVison is showing github.com — fix(android): gesture single tap incorrect event data by CatchABus · Pull Request #11632 · NativeScript/NativeScript
Conversation
CatchABus
commented
Nov 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
PR Checklist
What is the current behavior?
When an android view has both single and double tap gesture observers, it emits the tap event delay to leave a small time window for a possible double tap.
Unfortunately, the gesture emits the MotionEvent instance with a delay resulting in incorrect data (e.g. android event system resets the motion to event screen coordinates when done).
What is the new behavior?
These changes make sure that a copy of the motion event is kept before the timer.
The timer will emit the copy, hence the event data at the moment of the actual tap.
The PR also includes small changes regarding setTimeout.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
nx-cloud
Bot
commented
Nov 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
View your CI Pipeline Execution ↗ for commit 5df8a17
| Command |
Status |
Duration |
Result |
nx run-many -t build -p core,webpack5,vite |
✅ Succeeded |
19s |
View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-11-10 16:36:00 UTC
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
pkg-pr-new
Bot
commented
Nov 10, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Open in StackBlitz
npm i https://pkg.pr.new/@nativescript/core@11632
npm i https://pkg.pr.new/@nativescript/vite@11632
npm i https://pkg.pr.new/@nativescript/webpack@11632
commit: 5df8a17
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
clearTimeout(this._tapTimeoutId);
|
|
|
} else {
|
|
|
this._tapTimeoutId = null;
|
|
|
if (this._tapTimeoutId != null) {
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@farfromrefug I made this small change after the review and thought of letting you know.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.