GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(android): gesture single tap incorrect event data by CatchABus · Pull Request #11632 · NativeScript/NativeScript

Conversation

@CatchABus

@CatchABus CatchABus commented Nov 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Checklist

  • The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/CONTRIBUTING.md#commit-messages.
  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
  • You have signed the CLA.
  • All existing tests are passing: https://github.com/NativeScript/NativeScript/blob/master/tools/notes/DevelopmentWorkflow.md#unit-testing.
  • Tests for the changes are included - https://github.com/NativeScript/NativeScript/blob/master/tools/notes/WritingUnitTests.md.

What is the current behavior?

When an android view has both single and double tap gesture observers, it emits the tap event delay to leave a small time window for a possible double tap.
Unfortunately, the gesture emits the MotionEvent instance with a delay resulting in incorrect data (e.g. android event system resets the motion to event screen coordinates when done).

What is the new behavior?

These changes make sure that a copy of the motion event is kept before the timer.
The timer will emit the copy, hence the event data at the moment of the actual tap.
The PR also includes small changes regarding setTimeout.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CatchABus
fix(android): gesture single tap incorrect event data
08c38a9
@nx-cloud

nx-cloud Bot commented Nov 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 5df8a17

Command Status Duration Result
nx run-many -t build -p core,webpack5,vite ✅ Succeeded 19s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-11-10 16:36:00 UTC

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pkg-pr-new

pkg-pr-new Bot commented Nov 10, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nativescript/core@11632
npm i https://pkg.pr.new/@nativescript/vite@11632
npm i https://pkg.pr.new/@nativescript/webpack@11632

commit: 5df8a17

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CatchABus
ref: avoid unnecessary clear timeout calls
1f889a5
farfromrefug
farfromrefug approved these changes Nov 10, 2026
View reviewed changes
@CatchABus
perf: avoid unneeded clear timeout call
5df8a17
CatchABus
CatchABus commented Nov 10, 2026
View reviewed changes
Comment thread packages/core/ui/gestures/index.android.ts
clearTimeout(this._tapTimeoutId);
} else {
this._tapTimeoutId = null;
if (this._tapTimeoutId != null) {

@CatchABus CatchABus Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@farfromrefug I made this small change after the review and thought of letting you know.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@farfromrefug farfromrefug farfromrefug approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@CatchABus @farfromrefug
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.