GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — hhristov/recycle native view android by hshristov · Pull Request #3885 · NativeScript/NativeScript

Conversation

hshristov commented Mar 28, 2017

Copy link

Copy Markdown

Contributor

Rename:
_createNativeView to createNativeView;
_initNativeView to initNativeView
_disposeNativeView to disposeNativeView
_resetNativeView to resetNativeView

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

ns-bot added the cla: yes label

Mar 28, 2017

vakrilov approved these changes

Mar 28, 2017

View reviewed changes

Comment thread

tns-core-modules/ui/core/view-base/view-base.ts Outdated

		this.nativeView = this._iosView = (<any>this)._nativeView;
		this.createNativeView();
		if (!currentNativeView) {
		console.log(`${this.typeName} doesnt have NativeView !!!!! =================`);

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

console.log

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tns-core-modules/ui/date-picker/date-picker.android.ts


		[maxDateProperty.getDefault](): Date {
		return this.android.getMaxDate();
		return this.nativeView.getMaxDate();

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type should be number

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tns-core-modules/ui/date-picker/date-picker.android.ts Outdated

		return this.android.getMaxDate();
		return this.nativeView.getMaxDate();
		}
		[maxDateProperty.setNative](value: Date) {

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value type should be Date | number

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tns-core-modules/ui/date-picker/date-picker.android.ts


		[minDateProperty.getDefault](): Date {
		return this.android.getMinDate();
		return this.nativeView.getMinDate();

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type should be number

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tns-core-modules/ui/editable-text-base/editable-text-base.android.ts Outdated

		(<any>this.nativeView).listener.owner = null;
		}

		// public _resetNativeView(force?: boolean) {

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tns-core-modules/ui/html-view/html-view.ios.ts Outdated


		public onMeasure(widthMeasureSpec: number, heightMeasureSpec: number): void {
		var nativeView = this._nativeView;
		var nativeView = this._ios;

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this.nativeView

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

tns-core-modules/ui/time-picker/time-picker.android.ts Outdated

		}

		const validTime = getValidTime(timePicker, hour, minute);
		hourProperty.nativeValueChange(timePicker, validTime.hour);

vakrilov Mar 28, 2017

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete those - not needed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

vchimev approved these changes

Mar 28, 2017

View reviewed changes

Hristo Hristov added 4 commits

March 28, 2017 18:08


          NativeView recycled for android

f2898f8


          rename:

c18a76c

_createNativeView to createNativeView;
_initNativeView to initNativeView
_disposeNativeView to disposeNativeView
_resetNativeView to resetNativeView


          Resolving comments

84e726e


          Disable recycling of native views

e6250e7

createNativeView will set iOS nativeView if it is null/undefined

hshristov force-pushed the hhristov/recycle-native-view-android branch from d2ace2f to e6250e7 Compare

March 28, 2017 15:09

vchimev commented Mar 28, 2017

Copy link

Copy Markdown

Contributor

widgets

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vchimev commented Mar 28, 2017

Copy link

Copy Markdown

Contributor

widgets-uitests-android

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vchimev commented Mar 28, 2017

Copy link

Copy Markdown

Contributor

widgets-uitests-ios

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vchimev commented Mar 28, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

@hshristov,

there are some failures for iOS that require to look into them.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vchimev merged commit 86b9be3 into master

Mar 28, 2017

hshristov deleted the hhristov/recycle-native-view-android branch

March 30, 2017 14:32

lock Bot commented Aug 27, 2019

Copy link

Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

lock Bot locked and limited conversation to collaborators

Aug 27, 2019

Reviewers

2 more reviewers

vakrilov

vakrilov approved these changes

vchimev

vchimev approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

hshristov commented Mar 28, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vchimev commented Mar 28, 2017

Uh oh!

vchimev commented Mar 28, 2017

Uh oh!

vchimev commented Mar 28, 2017

Uh oh!

vchimev commented Mar 28, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lock Bot commented Aug 27, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vchimev commented Mar 28, 2017 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.