GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — refactor: restore animators api usage by manoldonev · Pull Request #6403 · NativeScript/NativeScript

Conversation

@manoldonev

@manoldonev manoldonev commented Oct 12, 2018

Copy link
Copy Markdown
Contributor

Related to #6129 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@manoldonev
feat: restore animators api usage
20688c5
@manoldonev manoldonev self-assigned this Oct 12, 2018
@ghost ghost added the in progress label Oct 12, 2018
@manoldonev

manoldonev commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

test branch_tests_app_transitions#mdonev/restore-animator-api animations testsappng
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ns-bot ns-bot added the cla: yes label Oct 12, 2018
@manoldonev manoldonev changed the title feat: restore animators api usage refactor: restore animators api usage Oct 12, 2018
@manoldonev
manoldonev requested review from ADjenkov, MartoYankov, vakrilov and vchimev October 12, 2018 11:25
@manoldonev

manoldonev commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

test --ignore animation_android animations_api23 branch_tests_app_transitions_android#mdonev/restore-animator-api tests_app_transitions_api23
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manoldonev

manoldonev commented Oct 12, 2018

Copy link
Copy Markdown
Contributor Author

test branch_tests_app_transitions#mdonev/restore-animator-api animations
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vakrilov
vakrilov approved these changes Oct 12, 2018
View reviewed changes
@SvetoslavTsenov

SvetoslavTsenov commented Oct 14, 2018

Copy link
Copy Markdown
Contributor

test --ignore branch_tests_app_transitions#mdonev/restore-animator-api animations api22 api19
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SvetoslavTsenov

SvetoslavTsenov commented Oct 14, 2018

Copy link
Copy Markdown
Contributor

test --ignore branch_tests_app_transitions#mdonev/restore-animator-api api22 api19
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@manoldonev
Merge branch 'master' into mdonev/restore-animator-api
d3c04f5
@manoldonev
manoldonev merged commit c8c0be7 into master Oct 16, 2018
@ghost ghost removed the in progress label Oct 16, 2018
@manoldonev
manoldonev deleted the mdonev/restore-animator-api branch October 16, 2018 12:38
@lock

lock Bot commented Oct 16, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lock lock Bot locked and limited conversation to collaborators Oct 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ADjenkov ADjenkov Awaiting requested review from ADjenkov
@MartoYankov MartoYankov Awaiting requested review from MartoYankov
@vchimev vchimev Awaiting requested review from vchimev
1 more reviewer
@vakrilov vakrilov vakrilov approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@manoldonev manoldonev

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@manoldonev @SvetoslavTsenov @vakrilov @ns-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.