GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||
GeezerVison is showing github.com — feat(): local icon handling in actionbar and tabview by MartoYankov · Pull Request #7009 · NativeScript/NativeScript Conversation
Contributor
PR Checklist
What is the current behavior?On Android, icons rendered in TabView and Actionbar are not scaled correctly due to the use of a deprecated native Android constructor https://developer.android.com/reference/android/graphics/drawable/BitmapDrawable#BitmapDrawable(android.graphics.Bitmap). On iOS, there was no property on ActionBar to specify icon rendering mode and it is hard coded to What is the new behavior?Fixed the Android issue with the use of the new constructor. Added Fixes #5887 Tests
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
MartoYankov
force-pushed
the
myankov/android-icons
branch
from
0d711d3 to
4206704
Compare
MartoYankov
force-pushed
the
myankov/android-icons
branch
from
c69fe70 to
89c96c8
Compare
Contributor
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
manoldonev
reviewed
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Guard the
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
manoldonev
approved these changes
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers1 more reviewerUh oh!
There was an error while loading. Please reload this page. AssigneesLabelsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Android uses deprecated method to create Drawable from BitmapUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | ||||||||||||||||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |