GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: Java methods returning java.lang primitive by farfromrefug · Pull Request #1710 · NativeScript/android

Conversation

@farfromrefug

@farfromrefug farfromrefug commented May 4, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

converted to JS corresponding type. This is an issue which always bugged me on difference between Float/Integer/Double/Long and basic float/int/long... handling

This is kind of a breaking change since JS codes doing floatValue() before wont work anymore and will crash.
We have a few in N core for which i ll create a PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@farfromrefug
feat: Java methods returning java.lang primitive
63b7725
converted to JS corresponding type
@cla-bot cla-bot Bot added the cla: yes label May 4, 2022
@triniwiz

triniwiz commented Sep 29, 2022

Copy link
Copy Markdown
Member

We can look this for the next major release

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@NathanWalker
NathanWalker changed the base branch from master to main November 21, 2022 18:12
@farfromrefug

farfromrefug commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

@triniwiz @NathanWalker can we consider this one now (needs to be updated though)? I am facing this again while implementing a new plugin where i have to pass new java.lang.Integer(value) which seems really unecessary. Also it is slower than handling it on the runtime side

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@farfromrefug

farfromrefug commented Jun 20, 2024

Copy link
Copy Markdown
Contributor Author

@triniwiz in this PR i handle callback return result type. And i see it is tricky as it is a breaking change.
Now i am facing the issue of java apis which sometimes takes a boolean as parameter and sometimes a java.lang.Boolean. I really would like the runtime to handle that automatically from a JS boolean.
Do you see where this would be happening? I am ok implementing it but i dont see where it would be done

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@triniwiz

triniwiz commented Jun 21, 2024

Copy link
Copy Markdown
Member

@farfromrefug in the converter when building the args we can try converting primitives to the objects.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@farfromrefug @triniwiz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.