GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: ability to embed into platform host projects by vmutafov · Pull Request #1799 · NativeScript/android

Conversation

@vmutafov

@vmutafov vmutafov commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
shiv19 reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@cla-bot cla-bot Bot added the cla: yes label Jan 2, 2024
@edusperoni
edusperoni changed the base branch from embed to main April 2, 2024 16:17
edusperoni
edusperoni reviewed Apr 2, 2024
View reviewed changes
Comment thread test-app/runtime/src/main/cpp/Version.h

@edusperoni edusperoni Apr 2, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be reverted

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test-app/runtime/src/main/java/com/tns/internal/Plugin.java

@edusperoni edusperoni Apr 2, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert to keep history clean

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test-app/runtime/build.gradle
Comment on lines +182 to +185
implementation "com.google.android.material:material:$androidXMaterialVersion"
implementation "androidx.appcompat:appcompat:$androidXAppCompatVersion"
implementation 'androidx.navigation:navigation-fragment-ktx:2.5.3'
implementation 'androidx.navigation:navigation-ui-ktx:2.5.3'

@edusperoni edusperoni Apr 2, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these needed? It'd mean all apps now depend on material, androidx navigation and appcompat

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test-app/app/src/main/java/com/tns/TestNativeScriptActivity.java Outdated

@edusperoni edusperoni Apr 2, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might need to be gitignored (NativeScriptActivity.java isn't currently committed into main)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread test-app/app/src/main/java/com/tns/TestNativeScriptApplication.java Outdated

@edusperoni edusperoni Apr 2, 2024

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file might need to be gitignored (NativeScriptApplication.java isn't currently committed into main)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@NathanWalker NathanWalker changed the title feat: add android embedding and merge main feat: ability to embed into platform host projects Jul 2, 2024
vmutafov and others added 5 commits July 8, 2024 15:22
@vmutafov @edusperoni
feat: support android embedding
496fcbb
@vmutafov @edusperoni
fix: remove NativeScriptActivity and NativeScriptApplication from git…
5015a54 
…ignore
@vmutafov @edusperoni
fix: use TestNativeScriptActivity and TestNativeScriptApplication whe…
62427bc 
…re necessary
@edusperoni
chore: re-add the runtime dependencies
1cf7105
@edusperoni
feat: remove deprecations and update error activity layout
34eaae5
@edusperoni
edusperoni force-pushed the embed branch from 869f046 to 34eaae5 Compare July 8, 2024 19:58
@edusperoni
fix: fix missing colors
be29f1e

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edusperoni edusperoni edusperoni left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vmutafov @edusperoni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.