GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fix: keep ErrorReportActivity content below the status bar on edge-to-edge by aleclarson · Pull Request #2054 · NativeScript/android

Conversation

aleclarson commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Closes #2053

Summary

The debug crash screen (com.tns.ErrorReportActivity / error_activity.xml) applies no window-insets handling, so on targetSdkVersion 35 — where Android 15 enforces edge-to-edge — the root RelativeLayout draws behind the status bar and clips the top errorException banner.
Adds android:fitsSystemWindows="true" to the root RelativeLayout, so the default inset dispatch pads the content by the system window insets (status bar, navigation bar, display cutout).
No-op on older targets and non-edge-to-edge windows, where the decor consumes those insets before they reach the content view. Side benefit: the bottom button rows now also clear the gesture/nav bar.
NativeScriptActivity lives in the app template, not this repo, and nothing here handles insets today, so there was no existing convention to match — this is the minimal fix suggested in the issue (SDK version 35 breaks the layout. It is stretched behind the status bar and the system bottom buttons. #1833 tracks the same root cause for normal app content).

Test plan

ns run android on an API 35 emulator/device, throw an uncaught JS exception on startup, confirm the red error banner renders fully below the status bar and the bottom buttons clear the nav bar
Repeat on a pre-35 device/emulator and confirm no layout change

Summary by CodeRabbit

Bug Fixes
- Updated the error screen layout to account for system window insets.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          fix: keep ErrorReportActivity content below the status bar on edge-to…

115c5e9

…-edge

targetSdk 35 forces edge-to-edge, so the debug crash screen's root layout
drew behind the status bar and clipped the top error banner. Setting
fitsSystemWindows on the root RelativeLayout pads the content by the
system window insets (status bar, nav bar, display cutout); it is a no-op
on older targets where the decor consumes those insets.

Closes NativeScript#2053

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 4a1337e8-4be6-4f40-b163-030ccff27ffd

📥 Commits

Reviewing files that changed from the base of the PR and between 6d16eb2 and 115c5e9.

📒 Files selected for processing (1)

test-app/app/src/debug/res/layout/error_activity.xml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

The debug error screen’s root RelativeLayout now enables android:fitsSystemWindows.

Changes

Debug error screen

Layer / File(s)	Summary
Enable system window fitting `test-app/app/src/debug/res/layout/error_activity.xml`	The root `RelativeLayout` sets `android:fitsSystemWindows` to `true`.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to 115c5

The debug error screen’s content is inset from the system bars, keeping its message and bottom controls clear. No actionable issue remains for merge.

Architecture Summary

Architecture risk: 🔵 Low · up to 115c5

The change affects 1 system.

Changed systems: test-app

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — test-app (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in test-app/app/src/debug/res/layout/error_activity.xml: The root RelativeLayout now enables fitsSystemWindows.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: keeping ErrorReportActivity content below the status bar during edge-to-edge display.
Linked Issues check	✅ Passed	The PR changes the debug `ErrorReportActivity` layout named in `#2053`. It adds `android:fitsSystemWindows="true"` to the root `RelativeLayout`, which matches the issue's suggested fix for applying syst…
Out of Scope Changes check	✅ Passed	The PR contains one layout change in `test-app/app/src/debug/res/layout/error_activity.xml`. The change directly supports `#2053` by adding inset handling to `ErrorReportActivity`. No unrelated implemen…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{A rabbit hops past the status bar,
And finds the error text in view.
The root now fits the window bounds,
With system insets accounted through.
One small line joins layout lore,
Then bunny bounds away once more.}

_{Comment @coderabbitai help to get the list of available commands.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ErrorReportActivity draws under the status bar on targetSdk 35 (forced edge-to-edge)

Uh oh!

There was an error while loading. Please reload this page.

1 participant

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

aleclarson commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

aleclarson commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.