GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ns clean - should remove yarn.lock if the package manager for the project is yarn · Issue #5732 · NativeScript/nativescript-cli

ns clean - should remove yarn.lock if the package manager for the project is yarn #5732

New issue
Copy link
New issue
Copy link
Open
Open
ns clean - should remove yarn.lock if the package manager for the project is yarn#5732
Copy link
Labels
feature
Milestone
9.0

Description

@shiv19
shiv19
opened on Apr 12, 2023
Issue body actions

Is your feature request related to a problem? Please describe.

When you run ns clean on a project that uses yarn as the package manager, the CLI still tries to remove a package-lock.json instead of yarn.lock

Describe the solution you'd like

If the package manager of the project is yarn, then ns clean should attempt to remove yarn.lock if it exists.

Describe alternatives you've considered

As an alternative, the developer could be prompted if they wish to remove yarn.lock or package-lock.json.

Anything else?

No response

Please accept these terms

  • I have searched the existing issues as well as StackOverflow and this has not been posted before
  • I agree to follow this project's Code of Conduct
Reacted by Nathan Walker

Activity

  1. shiv19
    added
    feature-pending-triageA new feature request pending triage to confirm validity.A new feature request pending triage to confirm validity.
    on Apr 12, 2023
  2. NathanWalker
    added this to the 8.6 milestone on Apr 12, 2023
  3. rigor789 commented on Apr 13, 2023

    @rigor789
    rigor789
    on Apr 13, 2023
    Member
    More actions

    For 8.6 we're likely going to remove the lockfiles from the default clean paths, and let users opt-in via their own configs... Which you can already do:

    cli: {
      additionalPathsToClean: ['yarn.lock']
    }

    /cc @edusperoni

    Reacted by Shiva Prasad and Eduardo Speroni
  4. rigor789
    added
    feature
    and removed
    feature-pending-triageA new feature request pending triage to confirm validity.A new feature request pending triage to confirm validity.
    on Apr 13, 2023
  5. NathanWalker
    modified the milestones: 8.6, 9.0 on Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    feature

    Type

    No type

    Projects

    No projects

      Milestone

      • 9.0No due date

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.