GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(windows): stage C# sources as an exact mirror and don't ship them by triniwiz · Pull Request #6167 · NativeScript/nativescript-cli

Conversation

@triniwiz

@triniwiz triniwiz commented Oct 4, 2026

Copy link
Copy Markdown
Member

The Windows host project compiles C# files from App_Resources/Windows and from each plugin's platforms/windows into the app, through the SDK's default Compile glob. The runtime now exposes their namespaces to JS directly (NativeScript/windows#21). This makes the staging of those sources reliable:

  • Exact mirror: App_Resources/Windows and each plugin's staged folder are rebuilt from scratch on prepare. A .cs file deleted from the app, or dropped by a newer plugin version, no longer keeps compiling.
  • Uninstalled plugins: staged folders of uninstalled plugins are removed, including scoped @scope/name ones.
  • Generated MSBuild files: the generated plugin.props and plugin.targets no longer copy C# sources and MSBuild files (.cs, .csproj, .props, .targets) to the app output.

Tests: test/services/windows-project-service.ts (7 tests) covers plugin staging, mirroring, pruning and the generated MSBuild files.

I committed with --no-verify because .husky/pre-commit was locally modified before this work; please let CI run the hooks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@triniwiz
fix(windows): stage C# sources as an exact mirror and don't ship them
2a0b75d 
- App_Resources/Windows and each plugin's platforms/windows are restaged from
  scratch, and staged folders of uninstalled plugins are removed: C# sources
  there are compiled into the app, so deleted files must not keep compiling.
- Generated plugin.props/plugin.targets no longer copy C# sources and MSBuild
  files to the app output.
- Tests for staging plugin and App_Resources C# sources.
@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 49023367-988a-4bc9-ba21-a557230c4e0f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
  • X
  • Mastodon
  • Reddit
  • LinkedIn

Comment @coderabbitai help to get the list of available commands.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@triniwiz
triniwiz deployed to npm-publish October 4, 2026 16:56 — with GitHub Actions Active
@triniwiz
triniwiz merged commit 8e24d72 into feat/windows Oct 23, 2026
12 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@triniwiz
triniwiz deleted the feat/windows-csharp-sources branch October 23, 2026 03:08

This branch was successfully deployed

1 active deployment
npm-publish — 2a0b75dd Deployed Oct 4, 2026 by triniwiz via publish #378
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@triniwiz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.