GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Compatibility with the vue-cli-template / HMR · Issue #65 · NativeScript/nativescript-dev-typescript

Compatibility with the vue-cli-template / HMR #65

New issue
Copy link
New issue
Copy link
Open
Open
Compatibility with the vue-cli-template / HMR#65
Copy link

Description

@EddyVerbruggen
EddyVerbruggen
opened on Sep 24, 2018
Issue body actions

Hi friends,

I was looking into using TypeScript with https://github.com/nativescript-vue/vue-cli-template and ran into an issue with the before-watch hook.

The template depends on bundling your code, even during development. That's also required to do HMR actually.

However, the before-watch hook skips TS compilation when bundling is in progress. So when a TS file is changed, the changes are not transpiled and the app is never updated with the new code. Sad.

I can fix this locally by commenting these lines in the hook:

nativescript-dev-typescript/lib/watch.js

Lines 6 to 9 in 814d533

if (appFilesUpdaterOptions.bundle) {
$logger.warn("Hook skipped because bundling is in progress.")
return;
}

Would it be a problem to simply remove the aforementioned check from this hook? It's the only thing stopping us from easily adding TS support to the Vue template.

Reacted by Jen Looper, TJ VanToll, Gerson E. Aguirre, Bundyo (Kamen Bundev), Nelson Nelson-Atuonwu, Alexander Soto, Jay and James

Activity

  1. EddyVerbruggen
    changed the title [-]Compatibility with the new NativeScript-Vue template[/-] [+]Compatibility with the vue-cli-template / HMR[/+] on Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      You are visitor 01402503 — GeezerVison does not store the pages you look up.
      Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.