GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CSTACKEX-379: Resolving comments received on Primary storage pool resize upstream PR by sandeeplocharla · Pull Request #136 · NetApp/cloudstack

Conversation

@sandeeplocharla

@sandeeplocharla sandeeplocharla commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR resolves the comments received on apache#14523

  1. The update storage pool now reuses the existing constants for flexVols.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sandeeplocharla
Resolved comment received
877f3e0
@sandeeplocharla
sandeeplocharla requested review from sathvikaragi and sp16743 November 10, 2026 13:07
@sandeeplocharla
sandeeplocharla requested review from piyush5netapp, rajiv-jain-netapp and suryag1201 as code owners November 10, 2026 13:07
@sandeeplocharla sandeeplocharla self-assigned this Nov 10, 2026
@github-actions

github-actions Bot commented Nov 10, 2026

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 25.83%
Branch coverage 20.12%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
piyush5netapp
piyush5netapp approved these changes Nov 12, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piyush5netapp piyush5netapp piyush5netapp approved these changes
@sathvikaragi sathvikaragi Awaiting requested review from sathvikaragi
@sp16743 sp16743 Awaiting requested review from sp16743
@rajiv-jain-netapp rajiv-jain-netapp Awaiting requested review from rajiv-jain-netapp rajiv-jain-netapp is a code owner
@suryag1201 suryag1201 Awaiting requested review from suryag1201 suryag1201 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sandeeplocharla sandeeplocharla

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@sandeeplocharla @piyush5netapp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.