GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: pin GitPython for release bump by AlexTranAmz · Pull Request #339 · OpenJobDescription/openjd-model-for-python

Conversation

@AlexTranAmz

@AlexTranAmz AlexTranAmz commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

python-semantic-release/python-semantic-release#1477 - GitPython break semantic, pin to an older version pending fixes from upstream

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@AlexTranAmz
AlexTranAmz requested a review from a team as a code owner August 25, 2026 21:42
leongdl
leongdl approved these changes Aug 25, 2026
View reviewed changes
@AlexTranAmz
chore: pin GitPython for release bump
10859df
Signed-off-by: AlexTranAmz <[email protected]>
@AlexTranAmz
AlexTranAmz force-pushed the pin-gitPython branch from 820599b to 10859df Compare August 25, 2026 21:46
@github-actions github-actions Bot added the waiting-on-maintainers label Aug 25, 2026
jericht
jericht approved these changes Aug 25, 2026
View reviewed changes
@leongdl
leongdl enabled auto-merge (rebase) August 25, 2026 21:55
@leongdl
leongdl merged commit 12816ad into OpenJobDescription:mainline Aug 25, 2026
30 of 31 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@AlexTranAmz
AlexTranAmz deleted the pin-gitPython branch August 25, 2026 21:56
github-actions[bot]
github-actions Bot reviewed Aug 25, 2026
View reviewed changes
Comment thread requirements-release.txt
@@ -1 +1,2 @@
python-semantic-release == 10.6.* No newline at end of file
python-semantic-release == 10.6.*
GitPython == 3.1.59 No newline at end of file

@github-actions github-actions Bot Aug 25, 2026

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitPython is not imported anywhere in this repo (grep -rn "import git" finds nothing) — it is a transitive dependency of python-semantic-release. Hard-pinning a transitive dep to an exact patch version has two downsides worth weighing:

  1. Resolver fragility. If a future python-semantic-release 10.6.x tightens its GitPython range past 3.1.59, pip install -r requirements-release.txt in the release env (hatch.toml:40) fails outright rather than resolving. The release-bump job then breaks for a reason unrelated to this repo.
  2. No patch uptake. GitPython has a history of security advisories (e.g. CVE-2022-24439, CVE-2023-40590, CVE-2023-41040 — untrusted search path / argument injection). An == pin means a fixed patch release will not be picked up until someone edits this line by hand.

Every other requirement in this repo uses a minor-series wildcard (python-semantic-release == 10.6.*, and all of requirements-testing.txt). Suggest matching that convention:

GitPython == 3.1.*

If an exact pin is deliberate — i.e. a specific GitPython release broke the bump — please add a short comment naming the breakage (as requirements-testing.txt:8-9 does for black), so a future reader knows when the pin can be relaxed. The commit message ("chore: pin GitPython for release bump") does not record the reason.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@leongdl leongdl leongdl approved these changes
+1 more reviewer
@jericht jericht jericht approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

waiting-on-maintainers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexTranAmz @jericht @leongdl
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.