GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove email related settings and disable email verification by jarifibrahim · Pull Request #224 · OpenSourceHelpCommunity/OpenSourceHelpCommunity.github.io

Conversation

@jarifibrahim

@jarifibrahim jarifibrahim commented Jan 5, 2018

Copy link
Copy Markdown
Member

We do not need email verification for new users right now.
Let's try to make sure basic features work well before adding optional features.

With the PR, email verification is disabled.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
houndci-bot
houndci-bot reviewed Jan 5, 2018
View reviewed changes
Comment thread oshc/oshc/settings.py Outdated
CRISPY_TEMPLATE_PACK = 'bootstrap3'

# Allauth settings
ACCOUNT_EMAIL_VERIFICATION = None # Disable email verification of new user

@houndci-bot houndci-bot Jan 5, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at least two spaces before inline comment

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jarifibrahim jarifibrahim mentioned this pull request Jan 5, 2018
Send emails to console backend when developing locally #223
Closed
1 of 3 tasks
@coveralls

coveralls commented Jan 5, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 72.269% when pulling 04f0e82 on jarifibrahim:remove-email into 3741eed on OpenSourceHelpCommunity:predev.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced Jan 5, 2018
Use env variables to set SMTP settings #222
Merged
Use environment variables to store SMTP credentials. #204
Closed
@jarifibrahim
jarifibrahim force-pushed the remove-email branch from 04f0e82 to cde9350 Compare January 5, 2018 17:24
@jarifibrahim
Remove email related settings and disable email verification
3c2c8a4
@jarifibrahim
jarifibrahim force-pushed the remove-email branch from cde9350 to 3c2c8a4 Compare January 5, 2018 17:25
@coveralls

coveralls commented Jan 5, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 72.269% when pulling 3c2c8a4 on jarifibrahim:remove-email into 3741eed on OpenSourceHelpCommunity:predev.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@coveralls

coveralls commented Jan 5, 2018

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 72.269% when pulling 3c2c8a4 on jarifibrahim:remove-email into 3741eed on OpenSourceHelpCommunity:predev.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tapaswenipathak
tapaswenipathak reviewed Jan 6, 2018
View reviewed changes
Comment thread oshc/oshc/settings.py
EMAIL_HOST_USER = 'email'
EMAIL_HOST_PASSWORD = 'password'
EMAIL_PORT = 587
EMAIL_USE_TLS = True

@tapaswenipathak tapaswenipathak Jan 6, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to try please go ahead and merge to predev, we need to make sure necessary issues are open. refing #222 (review).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tapaswenipathak tapaswenipathak Jan 6, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also have #202, we will keep this open and I feel fine with closing the mini ones, no probs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tapaswenipathak
Merge branch 'predev' into remove-email
f08e7ba
houndci-bot
houndci-bot reviewed Dec 16, 2018
View reviewed changes
Comment thread oshc/oshc/settings.py Outdated
EMAIL_HOST_PASSWORD = 'password'
EMAIL_PORT = 587
EMAIL_USE_TLS = True

@houndci-bot houndci-bot Dec 16, 2018

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tapaswenipathak
Merge branch 'predev' into remove-email
ab8fdb3
@tapaswenipathak
tapaswenipathak merged commit d84a0b7 into OpenSourceHelpCommunity:predev Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tapaswenipathak tapaswenipathak tapaswenipathak left review comments
+1 more reviewer
@houndci-bot houndci-bot houndci-bot left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jarifibrahim @coveralls @tapaswenipathak @houndci-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.