GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add clang-format checks in Danger by robertodr · Pull Request #3 · PCMSolver/danger-cpp-example

Conversation

@robertodr

@robertodr robertodr commented Aug 9, 2017

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@MinazoBot

MinazoBot commented Aug 9, 2017 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
1 Error
🚫 Code style violations detected.

Code Style Check


Code style violations detected in the following files:

  • hello_world.cpp

  • vector.cpp

Execute one of the following actions and commit again:

  1. Run clang-format on the offending files
  2. Apply the suggested patches with git apply patch.

hello_world.cpp

--- hello_world.cpp
+++ hello_world.cpp
@@ -4,13 +4,11 @@
 
 std::vector<int> myVector();
 
-std::string message() {
-         return "Hello, Danger world!";
-}
+std::string message() { return "Hello, Danger world!"; }
 
 int main() {
   std::cout << message() << std::endl;
 
-  std::vector< int  > v = myVector();
-        return EXIT_SUCCESS;
+  std::vector<int> v = myVector();
+  return EXIT_SUCCESS;
 }

vector.cpp

--- vector.cpp
+++ vector.cpp
@@ -1,13 +1,13 @@
 #include <vector>
 
 std::vector<int> myVector() {
-int arr[] = {16, 2, 77, 29};
-// Create a vector containing integers
-std::vector<int> v (arr, arr + sizeof(arr) /sizeof(arr[0]) );
+  int arr[] = {16, 2, 77, 29};
+  // Create a vector containing integers
+  std::vector<int> v(arr, arr + sizeof(arr) / sizeof(arr[0]));
 
-// Add two more integers to vector
-v.push_back(25);
-v.push_back(13);
+  // Add two more integers to vector
+  v.push_back(25);
+  v.push_back(13);
 
-return v;
+  return v;
 }

Generated by 🚫 Danger

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@robertodr
robertodr force-pushed the clang-format branch from 9a644a7 to a6d5852 Compare August 9, 2017 18:33
@robertodr
Add clang-format checks in Danger
d31022e
@robertodr
robertodr force-pushed the clang-format branch from fd406ca to d31022e Compare August 10, 2017 07:08
@robertodr
Add Travis job with GCC
c8f059d
@robertodr robertodr mentioned this pull request Aug 10, 2017
Add more file extensions flix-tech/danger-code_style_validation#8
Merged
4 tasks done
robertodr added 7 commits August 10, 2017 09:43
@robertodr
Execute Danger only once
62cd2d4
@robertodr
Update Gemfile.lock
4266dae
@robertodr
Update Gemfile.lock, remove one Danger plugin
b36ad19
@robertodr
Update usage of code style validation plugin
9f37fef
@robertodr
Add default.nix, install clang-format-3.9
8cfc4ae
@robertodr
Add .clang-format
31d0f30
@robertodr
Use offical 0.1.0 version of code style validation
5010c23
@orta orta mentioned this pull request Aug 18, 2017
Look into making it possible to provide diffs like this danger/danger-js#212
Open
@felipewaku felipewaku mentioned this pull request Sep 14, 2017
Improved feedback for code style violations indigotech/dangerjs-plugin#4
Open
@robertodr robertodr mentioned this pull request Sep 27, 2017
Set up integration with Danger.Systems psi4/psi4#809
Closed
7 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@robertodr @MinazoBot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.