GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — support buffer protocol in SFTPHandle.write by MartinNowak · Pull Request #244 · ParallelSSH/ssh2-python

Conversation

@MartinNowak

@MartinNowak MartinNowak commented Oct 13, 2026

Copy link
Copy Markdown
  • read simple buffer view to support same behavior as IOBase.write

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MartinNowak
support buffer protocol in SFTPHandle.write
2207f4d 
- read simple buffer view to support same behavior as IOBase.write
@MartinNowak
MartinNowak requested a review from pkittenis as a code owner October 13, 2026 17:00
MartinNowak
MartinNowak commented Oct 13, 2026
View reviewed changes
Comment thread ssh2/sftp_handle.pyx Resolved

Uh oh!

There was an error while loading. Please reload this page.
pkittenis
pkittenis approved these changes Oct 20, 2026
View reviewed changes

@pkittenis pkittenis left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

Would be good to also have other write functions, eg Channel.write, support buffer protocol, but can be separate changes.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pkittenis pkittenis pkittenis approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@MartinNowak @pkittenis
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.