GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add a downloader + verifier for static.rust-lang.org by emberian · Pull Request #179 · PistonDevelopers/VisualRust

Conversation

@emberian

@emberian emberian commented Aug 21, 2015

Copy link
Copy Markdown
Contributor

This is pretty primitive and completely synchronous with no progress notifications.

First step towards #172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Elaine Nemo
Add a downloader + verifier for static.rust-lang.org
e59a1e3 
This is pretty primitive and completely synchronous with no progress notifications.
vosen
vosen reviewed Aug 23, 2015
View reviewed changes
Comment thread VisualRust/Downloader.cs

@vosen vosen Aug 23, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a security person by any stretch of the imagination, so this might be dumb, but what does checking for exact cert fingerprint gives us?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@emberian emberian Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It gives us the knowledge that the connection isn't being MITM'd by any other certificates that may be trusted by the root CA store - either added by malware, compromised certificate, or just plain malice (which has been documented)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@emberian emberian Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's called certificate pinning, and browsers use it in the form of HSTS.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vosen

vosen commented Aug 23, 2015

Copy link
Copy Markdown
Member

I don't enforce any particular style of coding in this project, but please use camelCase for variables and function arguments.
i don't know which gpg4win build did you download, but in "vanilla" package, gpg2.exe and gpgconf.exe don't depend on libassuan-0.dll, giving a modest of saving of 69KB.
And a heads up, I'll merge this after releasing 0.1.1 into the wild, which will happen once I get my identity verified for code signing certificate, so this PR might linger here few days longer than seemingly necessary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

@vosen No problem! I'm glad we'll be getting a signing cert :) I'll clean up the style - C# isn't what I've used in any projects except minor "learn the language" programs. I'll poke around for something that doesn't depend on libassuan-0.dll
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

I'm back to uni tomorrow so I might be a bit slower than usual in responding, as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emberian

emberian commented Aug 24, 2015

Copy link
Copy Markdown
Contributor Author

Also, as detailed a review as you can give in regards to structure etc is useful for me - I don't do much programming in the OO style, and C# is a language I'm very weak in. Any avoidance of useful features or handy library things is not a guided choice, but just ignorance!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vosen

vosen commented Aug 27, 2015

Copy link
Copy Markdown
Member

Your style is OK, other than using a Gpg singleton. I know, we have some examples of this style in the codebase already, but it should be avoided. And I've noticed just now that the VS settings in ReinitializeGpgPaths are only read once, at the first use of Gpg. This is wrong, we won't apply any settings updates.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Boddlnagg

Boddlnagg commented Oct 10, 2016

Copy link
Copy Markdown
Contributor

I guess this is outdated and we should just wrap rustup instead, right? (Sorry for the wasted effort ...)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emberian @vosen @Boddlnagg
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.