GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add new function which checks for the proper version of dotnet by JamesWTruher · Pull Request #1131 · PowerShell/PSScriptAnalyzer

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Jan 20, 2019

Copy link
Copy Markdown
Contributor

This will improve the experience when the wrong version of dotnet is present by creating an error very early on in the process with a better error message

Now the developer will see something similar to the following:

PS /users/james/src/github/forks/JamesWTruher/PSScriptAnalyzer> ./build
Incorrect dotnet version: have '2.1.403' need '2.2.102'
At /users/james/src/github/forks/JamesWTruher/PSScriptAnalyzer/build.psm1:137 char:9
         throw 'Incorrect dotnet version: have '' need ' ...
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 CategoryInfo          : OperationStopped: (Incorrect dotne... need '2.2.102':String) [], RuntimeException
 FullyQualifiedErrorId : Incorrect dotnet version: have '2.1.403' need '2.2.102'

PR Summary

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
James Truher (JamesWTruher) requested a review from Christoph Bergmeister (bergmeister) January 20, 2019 21:19
@JamesWTruher
Add new function which checks for the proper version of dotnet
062fd10 
This will improve the experience when the wrong version of dotnet is present by creating an error very early on in the process with a better error message

Now the developer will see something similar to the following:
```
PS /users/james/src/github/forks/JamesWTruher/PSScriptAnalyzer> ./build
Incorrect dotnet version: have '2.1.403' need '2.2.102'
At /users/james/src/github/forks/JamesWTruher/PSScriptAnalyzer/build.psm1:137 char:9
         throw 'Incorrect dotnet version: have '' need ' ...
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 CategoryInfo          : OperationStopped: (Incorrect dotne... need '2.2.102':String) [], RuntimeException
 FullyQualifiedErrorId : Incorrect dotnet version: have '2.1.403' need '2.2.102'
```
@JamesWTruher
James Truher (JamesWTruher) force-pushed the checkdotnet branch from 5ca5f85 to 062fd10 Compare January 21, 2019 03:36
bergmeister
Christoph Bergmeister (bergmeister) requested changes Jan 21, 2019
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need this to work on the WMF4 build as well (it doesn't at the moment) and we should also remove/move existing code here that is used for CI to avoid duplication. There is a lot of handling for major/minor version, why not use the --list-sdks option instead to avoid handling those scenarios and also to not make it fail and just install the exact required version? In terms of handling the error and minor/major versions, I think dotnet build does that already together with global.json, so we should rather try to just rather try to propagate this error from the layering between build.ps1 and build.psm1 to the user.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher

James Truher (JamesWTruher) commented Feb 12, 2019

Copy link
Copy Markdown
Contributor Author

i'm closing this and will incorporate it into #1139
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JamesWTruher James Truher (JamesWTruher) closed this Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@JamesWTruher @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.