GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||||||||||||
GeezerVison is showing github.com — Azure pipelines migration by bergmeister · Pull Request #1267 · PowerShell/PSScriptAnalyzer Conversation
|
|
My current suspicion is that the Ubuntu 18.04 problems are caused by the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hmmmm just confirmed it wasn't that and haven't been able to reproduce yet on my ubuntu 18.04 VM |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
We should certainly be building the module to make sure it builds in CI, but not sure if you mean that there's another call to that build script elsewhere that outmodes it? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
# Conflicts: # Tests/Engine/CustomizedRule.tests.ps1
|
Close and re-open to see if things have changed and if the new Ubuntu failures on AppVeyor, happen here as well. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Hmmm, so it is reproducing in AzDO CI as well. After spending a day trying to reproduce this, I stopped trying when James Truher (@JamesWTruher) and I didn't see it in AzDO (only AppVeyor). Since this seems to be causing an issue in AzDO now, I'll go back to trying to reproduce it. I didn't have much luck replicating the AzDO environment locally... |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Maybe just ignoring the failures similar to the AppVeyor ones would be the best? Interestingly there were new AppVeyor AppVeyor failures just before xmas in AppVeyor but they have disappeared now |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Frustrating. But yes, I don't think these failures should block anything, so we should ignore them for now. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll open a PR to ignore them in AzDO |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I suggest to just add them in this PR here and use an environment variable that is only set in Az-Do |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Ok with you if I commit to this branch? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, please |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Getting this: Going to open a PR instead |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See bergmeister#11 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Exclude failing tests on AzDO/Ubuntu
|
Don't know why the push did not work, especially since I had the 'Allow edits from maintainers' checkbox ticked. Thanks for the PR of the PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Great, the Ubuntu build fails now because somehow after bootstrap the .net core sdk, it seems to lose it on the PATH env variable. Will merge bootstrap and build tasks into one then |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… into AzurePipelinesMigration Merge using HEAD, which reverts the last commit... # Conflicts: # build.psm1
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| inputs: | ||
| testRunner: NUnit | ||
| testResultsFiles: 'TestResults.xml' | ||
| condition: succeededOrFailed() No newline at end of file |
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Something that should be said is that although I set it to always run, but when the build or test fails, this task does not run and therefore test results are not uploaded. This seems to be a bug with the Azure DevOps YAML though. We should raise something but I don't think that's a blocking issue
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.