GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Azure pipelines migration by bergmeister · Pull Request #1267 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Jun 20, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

This is the minimum viable, lift and shift approach to have test running in Azure DevOps.
For better visibility in a PR I decided to create multiple build definitions instead of using multiple jobs in one build definition and another reason is that if one used multiple job in one build definition, one would not be able to see from which platform they came.
Good news: They pass on macOS but there are some test failures to be looked into for Ubuntu. I suggest to only validate against PS 5/6 on Windows and Mac and keep track of the Ubuntu failures until we have fixed them. Somehow there is also a bug in Azure DevOps where the task to upload test results it supposed to always run using succeededOrFailed but in practice it does not run if the previous task fails...

After this I suggest we only keep the PS v4 test in AppVeyor

Rob Holt (@rjmholt) Can I ask you please to look into the test failures from your compatibility module please? It seems that those tests pass on Ubuntu 16 but not Ubuntu 18, see related PR #1262 where I tried to fix the Ubuntu builds in AppVeyor. Also: I was not sure if we still need the calls to ./PSCompatibilityCollector/build.ps1 in the build yaml script?

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Christoph Bergmeister (bergmeister) added 20 commits June 16, 2019 12:13
@bergmeister
make ci scripts agnostic of CI provider
1516ff5
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
cc6464f
… into CI_NotAppVeyorSpecific
@bergmeister
Add basic yaml for testing in azure pipelines
a457ea7
@bergmeister
bootstrap template
16d1ae3
@bergmeister
fix whitespace. the joy of yaml
8e3ded0
@bergmeister
fix path
91c4ca7
@bergmeister
refactor
8025294
@bergmeister
test template
ec67d89
@bergmeister
fix yaml
e691f34
@bergmeister
publish test results
a46dbd3
@bergmeister
fix indentation
3f150ba
@bergmeister
unix yaml
15eacdb
@bergmeister
have bootstrap and build in the same task for unix
7eda9ad
@bergmeister
ps v5 template
d6bcc20
@bergmeister
ps v5 fix
79d3c85
@bergmeister
try to use template for pwsh in bootstrap
c55fd1e
@bergmeister
fix indent
6678f44
@bergmeister
fix template param for psv2
3b4a63c
@bergmeister
apply templating everywhere
f0376d8
@bergmeister
skip dontet cli init on v5 as well
cb7037e
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from James Truher (JamesWTruher) June 20, 2019 17:28
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Jun 22, 2019
@bergmeister
Fix custom rules tests that fail on Linux
7d4f0bf
@bergmeister
Christoph Bergmeister (bergmeister) requested a review from Rob Holt (rjmholt) June 22, 2019 07:12
@rjmholt

Rob Holt (rjmholt) commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

My current suspicion is that the Ubuntu 18.04 problems are caused by the LANG=C.UTF-8 locale change on that platform. I'll have a look into how dictionaries are built to make sure they're not taking the culture into account in any way.

JamesWTruher reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt

Rob Holt (rjmholt) commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

Hmmmm just confirmed it wasn't that and haven't been able to reproduce yet on my ubuntu 18.04 VM

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt

Rob Holt (rjmholt) commented Jun 28, 2019

Copy link
Copy Markdown
Contributor

Also: I was not sure if we still need the calls to ./PSCompatibilityCollector/build.ps1 in the build yaml script?

We should certainly be building the module to make sure it builds in CI, but not sure if you mean that there's another call to that build script elsewhere that outmodes it?

bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Christoph Bergmeister (bergmeister) added 3 commits July 5, 2019 20:50
@bergmeister
Add more assertion details to failure
377be99
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
4cff565
… into AzurePipelinesMigration
@bergmeister
Add more assertion message to other failures and fix property name on…
479a682
… it.
@bergmeister Christoph Bergmeister (bergmeister) closed this Aug 22, 2019
@bergmeister Christoph Bergmeister (bergmeister) reopened this Aug 22, 2019
@bergmeister
Merge branch 'master' into AzurePipelinesMigration
0289308
# Conflicts:
#	Tests/Engine/CustomizedRule.tests.ps1
@bergmeister

Christoph Bergmeister (bergmeister) commented Oct 27, 2019

Copy link
Copy Markdown
Collaborator Author

Close and re-open to see if things have changed and if the new Ubuntu failures on AppVeyor, happen here as well.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister Christoph Bergmeister (bergmeister) closed this Oct 27, 2019
@bergmeister Christoph Bergmeister (bergmeister) reopened this Oct 27, 2019
@bergmeister Christoph Bergmeister (bergmeister) closed this Jan 2, 2020
@bergmeister Christoph Bergmeister (bergmeister) reopened this Jan 2, 2020
@rjmholt

Rob Holt (rjmholt) commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

Hmmm, so it is reproducing in AzDO CI as well. After spending a day trying to reproduce this, I stopped trying when James Truher (@JamesWTruher) and I didn't see it in AzDO (only AppVeyor).

Since this seems to be causing an issue in AzDO now, I'll go back to trying to reproduce it. I didn't have much luck replicating the AzDO environment locally...

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator Author

Maybe just ignoring the failures similar to the AppVeyor ones would be the best? Interestingly there were new AppVeyor AppVeyor failures just before xmas in AppVeyor but they have disappeared now

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt

Rob Holt (rjmholt) commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

Frustrating. But yes, I don't think these failures should block anything, so we should ignore them for now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt

Rob Holt (rjmholt) commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

I'll open a PR to ignore them in AzDO

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator Author

I suggest to just add them in this PR here and use an environment variable that is only set in Az-Do

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt

Rob Holt (rjmholt) commented Jan 3, 2020

Copy link
Copy Markdown
Contributor

I suggest to just add them in this PR here and use an environment variable that is only set in Az-Do

Ok with you if I commit to this branch?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 3, 2020

Copy link
Copy Markdown
Collaborator Author

Yes, please

rjmholt reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Rob Holt
Exclude failing tests on AzDO/Ubuntu
385febf
@rjmholt

Rob Holt (rjmholt) commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

Getting this:

To https://github.com/bergmeister/PSScriptAnalyzer
 ! [remote rejected] AzurePipelinesIntegration -> AzurePipelinesIntegration (permission denied)
error: failed to push some refs to 'https://github.com/bergmeister/PSScriptAnalyzer'

Going to open a PR instead

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@rjmholt

Rob Holt (rjmholt) commented Jan 7, 2020

Copy link
Copy Markdown
Contributor

See bergmeister#11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Merge pull request #11 from rjmholt/AzurePipelinesIntegration
ed81374
Exclude failing tests on AzDO/Ubuntu
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 7, 2020

Copy link
Copy Markdown
Collaborator Author

Don't know why the push did not work, especially since I had the 'Allow edits from maintainers' checkbox ticked. Thanks for the PR of the PR.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

Great, the Ubuntu build fails now because somehow after bootstrap the .net core sdk, it seems to lose it on the PATH env variable. Will merge bootstrap and build tasks into one then

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Christoph Bergmeister (bergmeister) added 4 commits January 7, 2020 19:54
@bergmeister
try fix ubuntu build where dotnet --version makes the pipeline stop i…
ccb4e91
…n Az-Do
@bergmeister
Merge branch 'master' of https://github.com/PowerShell/PSScriptAnalyzer…
cc706d2
… into AzurePipelinesMigration

Merge using HEAD, which reverts the last commit...
# Conflicts:
#	build.psm1
@bergmeister
Bootstrap as part of build process
a350326
@bergmeister
remove bootstrap.yaml, which is now not needed any more
b44c9a9
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 7, 2020

Copy link
Copy Markdown
Collaborator Author

Yippee, it's finally green. Now, I have to do a self-review as well as some things might've changed since then.
For example I created a build definition for each type of hosted agent image as there was a dropdown (this allowed to report them indiviudally in GitHub). Now there is only the previously chosen option left in the dropdown, which means that we could not add a new build definition with a new image. Therefore I think it might be better to put the image into YAML as well now and use only 1 build definition. What do you think?
image

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bergmeister
Christoph Bergmeister (bergmeister) commented Jan 7, 2020
View reviewed changes
Comment thread .azure-pipelines-ci/templates/test.yaml
inputs:
testRunner: NUnit
testResultsFiles: 'TestResults.xml'
condition: succeededOrFailed() No newline at end of file

@bergmeister Christoph Bergmeister (bergmeister) Jan 7, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something that should be said is that although I set it to always run, but when the build or test fails, this task does not run and therefore test results are not uploaded. This seems to be a bug with the Azure DevOps YAML though. We should raise something but I don't think that's a blocking issue

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@rjmholt Rob Holt (rjmholt) Jan 7, 2020

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James Truher (@JamesWTruher) FYI

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
re-trigger sporadic failure
bc53763
JamesWTruher
James Truher (JamesWTruher) approved these changes Jan 28, 2020
View reviewed changes

@JamesWTruher James Truher (JamesWTruher) left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 8b2c02d into PowerShell:master Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmholt Rob Holt (rjmholt) Awaiting requested review from rjmholt
1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @rjmholt @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.