GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update documentation for parameter "Settings" of command "Invoke-ScriptAnalyzer" to include the key "RecurseCustomRulesPath" by travisclagrone · Pull Request #1272 · PowerShell/PSScriptAnalyzer

Conversation

@travisclagrone

@travisclagrone Travis C. LaGrone (travisclagrone) commented Jun 23, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #1270 "Documentation for Invoke-ScriptAnalyzer -Settings is out-of-date".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@travisclagrone
Update documentation for parameter "Settings" of command "Invoke-Scri…
071b360 
…ptAnalyzer" to include the key "RecurseCustomRulesPath"
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Documentation label Jun 24, 2019
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jun 29, 2019
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, what about sorting the parameters alphabetically?
Also, if you use an issue closing keyword in the description, then the issue gets closed automatically:
https://help.github.com/en/articles/closing-issues-using-keywords

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@travisclagrone
Order documentary key list for Invoke-ScriptAnalyzer -Settings alphab…
2ac75c5 
…etically
@travisclagrone

Travis C. LaGrone (travisclagrone) commented Jun 29, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

Christoph Bergmeister (@bergmeister)

Looks good to me, what about sorting the parameters alphabetically?
Also, if you use an issue closing keyword in the description, then the issue gets closed automatically:
https://help.github.com/en/articles/closing-issues-using-keywords

Done and done.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jun 29, 2019
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 88056ac into PowerShell:master Jun 29, 2019
@travisclagrone
Travis C. LaGrone (travisclagrone) deleted the update-documentation-for-Invoke-ScriptAnalyzer_-Settings branch June 29, 2019 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Documentation for Invoke-ScriptAnalyzer -Settings is out-of-date

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@travisclagrone @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.