GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add icon and add reference in readme and manifest by bergmeister · Pull Request #1291 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Jul 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

Adil Leghari (@adilio) was kind enough to create a logo. This adds it to the main readme so that it is visible when browsing it to the repo and the module manifest so that it appears on the PSGallery.
The logo was taken from his repo, which is under MIT:
https://github.com/adilio/ps-design/tree/master/psscriptanalyzer
I have tested that the icon gets displayed correctly by uploading this test module: https://www.poshtestgallery.com/packages/foo/0.0.5

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Christoph Bergmeister (bergmeister) added 2 commits July 13, 2019 20:45
@bergmeister
Add icon and add reference in readme and manifest
d2ea75c
@bergmeister
correct ratio
a24537d
@adilio

Adil Leghari (adilio) commented Jul 13, 2019

Copy link
Copy Markdown

Hey Christoph Bergmeister (@bergmeister), the icon in the test PSGallery is.... umm.... triggering my OCD 😅.

If you'd like to get the dimensions required, I can create a properly-scaled file for you?

Also, just thought I'd pass on that, when placing an img HTML tag referencing images, I find it's easier to just define one dimension. That way, the other dimension is automatically calculated to be the correct ratio, and you don't have to worry about pixelation from slight differences.

Just my 2 pesos 🙂.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
simplify html img tag to auto calculate height
f3bffa8
@bergmeister

Christoph Bergmeister (bergmeister) commented Jul 13, 2019 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author

Thanks for the tip with the img tag, that makes it easier.
I am not sure what the requirements are for the PSGallery but to me it seems that they resize the image to be square. Do you have a preference on being acknowledged in a certain way (e.g. to have a Readme in the assets folder to point to your original source)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@adilio

Adil Leghari (adilio) commented Jul 13, 2019

Copy link
Copy Markdown

Understood. I have just pushed two new versions to the repo. Both have a square base image size, so it won't skew images at all. One is original size, one is at 300px.

https://github.com/adilio/ps-design/blob/master/psscriptanalyzer/pssa-logo-square.png
https://github.com/adilio/ps-design/blob/master/psscriptanalyzer/pssa-logo-square-300.png

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
use square logo
adeeb00
@bergmeister

Christoph Bergmeister (bergmeister) commented Jul 21, 2019

Copy link
Copy Markdown
Collaborator Author

Thanks Adil Leghari (@adilio)
I updated the logo in the published test module and in this PR to use the new square logo. This is how it'd look like now:
https://www.poshtestgallery.com/packages/foo/0.0.5

adilio reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review August 18, 2019 08:52
@JamesWTruher
James Truher (JamesWTruher) merged commit a449c2c into PowerShell:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@bergmeister @adilio @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.