GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update Newtonsoft json to 12.0.1 due to PowerShell 6.1 going out of support by bergmeister · Pull Request #1336 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Sep 12, 2019

Copy link
Copy Markdown
Collaborator

PR Summary

This implicitly ups the minimum requirement for PS Core to 6.2.0 (because PowerShell cannot load a newer version of Newtonsoft than the version that it ships with). This is OK because PS 6.1 will go out of support in a week anyway.
I had to change the AppVeyor image to a newer one to get PS 6.2.0. If that AppVeyor had a newer patch of 6.2 then we could've even upgraded to Newtonsoft 12.0.2 (PowerShell 6.2.1 started shipping with this patch)

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) added 3 commits September 11, 2019 19:20
@bergmeister
Upgrade NewtonSoft.Json to the version that PS 6.2.1 ships with as PS…
daf1499 
… 6.1 is going out of support now
@bergmeister
Upgrade AppVeyor image to use PS 6.2
808b7b8
@bergmeister
Downgrade to PS 6.2.0 as a minimum PS version due to AppVeyor
a3f2363
@bergmeister Christoph Bergmeister (bergmeister) added Area - Build Breaking Change labels Sep 12, 2019
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) September 12, 2019 19:38
JamesWTruher
James Truher (JamesWTruher) approved these changes Sep 12, 2019
View reviewed changes
JamesWTruher
James Truher (JamesWTruher) approved these changes Sep 12, 2019
View reviewed changes
@JamesWTruher
James Truher (JamesWTruher) merged commit b9fd7b3 into PowerShell:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rjmholt Rob Holt (rjmholt) Awaiting requested review from rjmholt
1 more reviewer
@JamesWTruher James Truher (JamesWTruher) JamesWTruher approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build Breaking Change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @JamesWTruher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.