GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update AzF profile to be useful by rjmholt · Pull Request #1341 · PowerShell/PSScriptAnalyzer

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Sep 13, 2019

Copy link
Copy Markdown
Contributor

PR Summary

I've run the profile collector on the AzF profile (with some difficulty) and collected a new profile that captures the default Az installation.

I've also removed cmdlets that don't work in AzF despite being present, like Start-Job and Enter-PSSession.

I had to make some small changes to the profile collector to not crash (plus one where I realised that collecting a function if we're not able to load it is unhelpful).

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rob Holt (rjmholt) added 2 commits September 13, 2019 15:23
@rjmholt
Fix collection issue
225f004
@rjmholt
Update AzF profile to be useful
098e4c0
bergmeister
Christoph Bergmeister (bergmeister) reviewed Sep 13, 2019
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me but it broke 1 CI test:

    Context Targeting new-form Az profiles alongside older profiles
      [-] Finds AzF problems with a script 7.37s
        KeyNotFoundException: The given key 'InDisconnectedSession' was not present in the dictionary.
        at <ScriptBlock>, C:\projects\psscriptanalyzer\Tests\Rules\UseCompatibleCommands.Tests.ps1: line 334

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@rjmholt

Rob Holt (rjmholt) commented Sep 13, 2019

Copy link
Copy Markdown
Contributor Author

Impressive that testing picked that up! I'll have to make some further edits
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt
Fix alias
0c5e342
@rjmholt

Rob Holt (rjmholt) commented Sep 14, 2019

Copy link
Copy Markdown
Contributor Author

Impressive that testing picked that up!

Have to credit you entirely for that Christoph Bergmeister (@bergmeister) -- you asked for those tests.

Looks like they're working now. Hopefully the Lazys don't hide other faults. I took out parameters and commands manually, and it looks like I took a parameter out without its alias there.
bergmeister reacted with laugh emoji bergmeister reacted with hooray emoji
All reactions
  • 😄 1 reaction
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Sep 14, 2019
View reviewed changes
@rjmholt
Rob Holt (rjmholt) merged commit 5e207aa into PowerShell:master Sep 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rjmholt @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.