GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Harden handling when getting the installed dotnet cli version by JamesWTruher · Pull Request #1367 · PowerShell/PSScriptAnalyzer

Conversation

@JamesWTruher

@JamesWTruher James Truher (JamesWTruher) commented Nov 5, 2019

Copy link
Copy Markdown
Contributor

PR Summary

dotnet --version can now emit a list of installed sdks as output and an error if the global.json
file points to a version of the sdk which is not installed. However, the format of the new list
with --version has a couple of spaces at the beginning of the line, so we need to be resilient
against that.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JamesWTruher
James Truher (JamesWTruher) requested review from Christoph Bergmeister (bergmeister) and Rob Holt (rjmholt) November 5, 2019 19:42
@JamesWTruher James Truher (JamesWTruher) added the Area - Build label Nov 5, 2019
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Nov 5, 2019
View reviewed changes
@bergmeister Christoph Bergmeister (bergmeister) mentioned this pull request Nov 6, 2019
A new hosting model which is easier for Editor Services and other script analyzer hosting #1361
Closed
4 of 6 tasks
@JamesWTruher
Harden dotnet --version handling
ffe499c 
dotnet --version can now emit a list of installed sdks as output *and* an error if the global.json
file points to a version of the sdk which is *not* installed. However, the format of the new list
with --version has a couple of spaces at the beginning of the line, so we need to be resilient
against that.
@JamesWTruher
James Truher (JamesWTruher) force-pushed the BuildScriptFix01 branch from 41c8013 to ffe499c Compare November 11, 2019 22:49
rjmholt
Rob Holt (rjmholt) approved these changes Nov 13, 2019
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit cdc5cf3 into PowerShell:master Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
+1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JamesWTruher @rjmholt @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.