GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Remove redundant whitespace between parameters with new option (disabled by default) in UseConsistentWhitespace by bergmeister · Pull Request #1392 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Jan 5, 2020

Copy link
Copy Markdown
Collaborator

PR Summary

Disabled by default because it is new. The plan is to later add an option to the vs code extension and pending positive feedback we can then later enable it by default.
The only case that was excluded by design is when the user uses the -ParameterName:$ParameterValue syntax as some people might prefer 0 or 1 whitespace here, the rule leaves those cases completely untouched.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Christoph Bergmeister (bergmeister) and others added 5 commits January 4, 2020 22:42
@bergmeister
find extents of parameters elements
aada802
Christoph Bergmeister
first working prototype
a240bd5
Christoph Bergmeister
Productionize, add tests, docs and add to config files. TODO: message…
5d3384e
… names
Christoph Bergmeister
tidy up
df26814
Christoph Bergmeister
add messages
7b7d4fa
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Formatter label Jan 5, 2020
@bergmeister Christoph Bergmeister (bergmeister) changed the title Remove redundant white space between parameters with new option (disabled by default) in UseConsistentWhitespace Remove redundant whitespace between parameters with new option (disabled by default) in UseConsistentWhitespace Jan 5, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) January 6, 2020 17:58
rjmholt
Rob Holt (rjmholt) reviewed Jan 6, 2020
View reviewed changes
Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Rules/UseConsistentWhitespace.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Tests/Rules/UseConsistentWhitespace.tests.ps1 Resolved

Uh oh!

There was an error while loading. Please reload this page.

Christoph Bergmeister (bergmeister) and others added 4 commits January 6, 2020 21:39
@bergmeister @rjmholt
Apply suggestions from code review
96b62d6
Co-Authored-By: Robert Holt <[email protected]>
Christoph Bergmeister
revert suggestion around removal around expectedStartColumnNumberOfRi…
e150a2f
…ghtExtent variable, which broke build.

Variable is used 2 times and makes code more readable, therefore keeping it
Christoph Bergmeister
Tweak DiagnosticRecord creation and add more tests
8f6625c
Christoph Bergmeister
use named parameters for CorrectionExtent constructor
0e004cd
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 6, 2020

Copy link
Copy Markdown
Collaborator Author

Rob Holt (@rjmholt) Thanks for the review, I addressed all recommendations

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rjmholt
Rob Holt (rjmholt) approved these changes Jan 6, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit b0a67c7 into PowerShell:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Formatter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.