GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix ps3 syntax check by rjmholt · Pull Request #1395 · PowerShell/PSScriptAnalyzer

Conversation

@rjmholt

@rjmholt Rob Holt (rjmholt) commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Fixes #1384.

UseCompatibleSyntax used to erroneously advise that dynamic member expressions don't work in PS 3. Now it does not.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Rob Holt (rjmholt) added 4 commits January 15, 2020 17:20
@rjmholt
Remove erroneous ps3 dynamic member warning
5a42e28
@rjmholt
Upgrade compatible syntax rule to emit errors
0a74ee6
@rjmholt
Fix tests
8bde76d
@rjmholt
Fix last test
4e1bfeb
bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 16, 2020
View reviewed changes

@bergmeister Christoph Bergmeister (bergmeister) left a comment

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the question around why severity changed, looks ok but the build is not green, therefore once the build is green, I think it can go in

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Rules/CompatibilityRules/UseCompatibleSyntax.cs Resolved

Uh oh!

There was an error while loading. Please reload this page.
@rjmholt

Rob Holt (rjmholt) commented Jan 16, 2020

Copy link
Copy Markdown
Contributor Author

looks ok but the build is not green, therefore once the build is green, I think it can go in

100% agreed, will work on that this week hopefully.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Rob Holt
Fix tests to account for severity change
fc0ccbe
@bergmeister
Christoph Bergmeister (bergmeister) merged commit a415198 into PowerShell:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Question about PSUseCompatibleSyntax

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@rjmholt @bergmeister
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.