GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update adopters file with entry for Microsoft internal teams by pperrier27 · Pull Request #1398 · PowerShell/PSScriptAnalyzer

Conversation

@pperrier27

@pperrier27 pperrier27 commented Jan 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR Summary

Update the adopters file with an entry for internal Microsoft teams.

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pperrier27
Updated adopters file
f2938e2
@bergmeister

Christoph Bergmeister (bergmeister) commented Jan 17, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Hmm, that is kind of what every company, including mine does and what the main use case of PSSA is.
I think adopters is more for people who actually ship or use PSSA as part of their product. WDYT Steve Lee (@SteveL-MSFT)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@SteveL-MSFT

Steve Lee (SteveL-MSFT) commented Jan 17, 2020

Copy link
Copy Markdown
Member

Christoph Bergmeister (@bergmeister) I think any company using PSSA in production and willing to advertise that should be in adopters. If it's only for products that ship/use PSSA, it would be a very short list. Looking at other OSS projects with Adopters.md, it's not just for products.
bergmeister reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bergmeister
Christoph Bergmeister (bergmeister) reviewed Jan 17, 2020
View reviewed changes
Comment thread ADOPTERS.md Outdated

This is a list of adopters of using PowerShell Script Analyzer in production or in their products (in alphabetical order):

* Microsoft internal: teams within Microsoft use Powershell Script Analyzer to maintain and improve the quality of the Powershell code they write.

@bergmeister Christoph Bergmeister (bergmeister) Jan 17, 2020

Copy link
Copy Markdown
Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Microsoft internal: teams within Microsoft use Powershell Script Analyzer to maintain and improve the quality of the Powershell code they write.
* Microsoft internal: Teams within Microsoft use Powershell Script Analyzer to maintain and improve the quality of the Powershell code they write.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jan 17, 2020
View reviewed changes
@bergmeister Christoph Bergmeister (bergmeister) changed the title Update adopters file with entry for Mcrosoft internal teams Update adopters file with entry for Microsoft internal teams Jan 17, 2020
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Documentation label Jan 17, 2020
@pperrier27
Update wording in adopters file
a669c89
bergmeister
Christoph Bergmeister (bergmeister) approved these changes Jan 17, 2020
View reviewed changes
SteveL-MSFT
Steve Lee (SteveL-MSFT) approved these changes Jan 18, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit fec0452 into PowerShell:master Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bergmeister Christoph Bergmeister (bergmeister) bergmeister approved these changes
@SteveL-MSFT Steve Lee (SteveL-MSFT) SteveL-MSFT approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@pperrier27 @bergmeister @SteveL-MSFT
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.