GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Use vmImage in yaml and merge build definitions into 1 by using jobs. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI by bergmeister · Pull Request #1403 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Feb 2, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

  • Use vmImage in yaml to merge all build definitions into 1 PSScriptAnalyzer-CI build definition by using jobs instead of defining the image in the build definition itself. This means the Ubuntu/macOs/Windows specific build definitions can be deleted after this PR. This reduces maintenance in Azure DevOps and makes it easier for us adapt for upcoming image changes. With that we now also test against both Ubuntu versions and using jobs prepares us for using multi-stage pipelines as the next step (there isn't really a benefit in terms of time-savings though). In a PR the individual stages are reported individually but I don't think we can have badges for the individual jobs.
  • Since Azure DevOps seems to work fine, we can disable the other images in AppVeyor except for WMF4, for which Azure Pipelines does not have a hosted image for
  • The sporadic failures in the UseCompatibleCommand test suite change over time, therefore disabling the test cases individually was not working well.
  • Add build badge

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Christoph Bergmeister (bergmeister) added 10 commits February 2, 2020 16:19
@bergmeister
try using multi-job yaml with different images
e7a7c54
@bergmeister
fix indentation
2e4c403
@bergmeister
add vm images to windows build and templatify unix build. Images now …
e669e48
…are latest ubuntu image
@bergmeister
trigger
ca51510
@bergmeister
fix yaml path
ac4894c
@bergmeister
disable sporadic tests generally and add both Ubuntu images to the tests
d2188be
@bergmeister
job name in quotes and disable redundant appveyor matrix entries
ba896ab
@bergmeister
whitespace not allowed for job name
c50c02a
@bergmeister
dots arent allowed either...
ec0fcb7
@bergmeister
last fix
4afd0c6
@bergmeister Christoph Bergmeister (bergmeister) changed the title WIP: try using multi-job yaml with different images Use vmImage in yaml to merge Ubuntu%macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Feb 2, 2020
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) February 2, 2020 20:01
@bergmeister Christoph Bergmeister (bergmeister) changed the title Use vmImage in yaml to merge Ubuntu%macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Use vmImage in yaml to merge Ubuntu & macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Feb 2, 2020
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Feb 2, 2020
@bergmeister
Merge all entry path yaml files into one yaml.ci file
a503c15
@bergmeister Christoph Bergmeister (bergmeister) changed the title Use vmImage in yaml to merge Ubuntu & macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Use vmImage in yaml and merge build definitions into 1 by using jobs. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI Feb 2, 2020
Christoph Bergmeister (bergmeister) added 2 commits February 2, 2020 20:32
@bergmeister
fix windows powershell job
e31aead
@bergmeister
tweak step name for ps5 to be consistent
06d6631
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review February 2, 2020 20:38
Christoph Bergmeister (bergmeister) added 2 commits February 2, 2020 20:43
@bergmeister
re-trigger
9c4445b
@bergmeister
add badge
dfe241a
rjmholt
Rob Holt (rjmholt) approved these changes Feb 3, 2020
View reviewed changes
@bergmeister
Christoph Bergmeister (bergmeister) merged commit d5cb76f into PowerShell:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.