GeezerVison is showing github.com — Use vmImage in yaml and merge build definitions into 1 by using jobs. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI by bergmeister · Pull Request #1403 · PowerShell/PSScriptAnalyzer
Conversation
PR Summary
- Use
vmImage in yaml to merge all build definitions into 1 PSScriptAnalyzer-CI build definition by using jobs instead of defining the image in the build definition itself. This means the Ubuntu/macOs/Windows specific build definitions can be deleted after this PR. This reduces maintenance in Azure DevOps and makes it easier for us adapt for upcoming image changes. With that we now also test against both Ubuntu versions and using jobs prepares us for using multi-stage pipelines as the next step (there isn't really a benefit in terms of time-savings though). In a PR the individual stages are reported individually but I don't think we can have badges for the individual jobs.
- Since Azure DevOps seems to work fine, we can disable the other images in AppVeyor except for WMF4, for which Azure Pipelines does not have a hosted image for
- The sporadic failures in the
UseCompatibleCommand test suite change over time, therefore disabling the test cases individually was not working well.
- Add build badge
PR Checklist
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Christoph Bergmeister (bergmeister)
changed the title
WIP: try using multi-job yaml with different images
Use vmImage in yaml to merge Ubuntu%macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI
Feb 2, 2020
Christoph Bergmeister (bergmeister)
changed the title
Use vmImage in yaml to merge Ubuntu%macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI
Use vmImage in yaml to merge Ubuntu & macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI
Feb 2, 2020
Christoph Bergmeister (bergmeister)
changed the title
Use vmImage in yaml to merge Ubuntu & macOS build definitions into 1 'Unix' build definition. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI
Use vmImage in yaml and merge build definitions into 1 by using jobs. Disable all AppVeyor images except for WMF4. Disable flaky UseCompatibleCommand tests on Ubuntu in CI
Feb 2, 2020
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.