GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Multi-stage pipelines (to split build->test) by bergmeister · Pull Request #1404 · PowerShell/PSScriptAnalyzer

Conversation

@bergmeister

@bergmeister Christoph Bergmeister (bergmeister) commented Feb 3, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

PR Summary

This also makes the test matrix much bigger because it's free due to parallelism.

Somehow this also exposed a small bug in a rule around newlines that I had to fix as part of it.

PR Checklist

  • PR has a meaningful title](https://github.com/PowerShell/PowerShell/blob/master/.github/CONTRIBUTING.md#pull-request---submission)
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Change is not breaking
  • Make sure all .cs, .ps1 and .psm1 files have the correct copyright header
  • Make sure you've added a new test if existing tests do not effectively test the code changed and/or updated documentation
  • This PR is ready to merge and is not Work in Progress.
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Christoph Bergmeister (bergmeister) and others added 16 commits February 2, 2020 16:19
@bergmeister
try using multi-job yaml with different images
e7a7c54
@bergmeister
fix indentation
2e4c403
@bergmeister
add vm images to windows build and templatify unix build. Images now …
e669e48 
…are latest ubuntu image
@bergmeister
trigger
ca51510
@bergmeister
fix yaml path
ac4894c
@bergmeister
disable sporadic tests generally and add both Ubuntu images to the tests
d2188be
@bergmeister
job name in quotes and disable redundant appveyor matrix entries
ba896ab
@bergmeister
whitespace not allowed for job name
c50c02a
@bergmeister
dots arent allowed either...
ec0fcb7
@bergmeister
last fix
4afd0c6
@bergmeister
Merge all entry path yaml files into one yaml.ci file
a503c15
@bergmeister
fix windows powershell job
e31aead
@bergmeister
tweak step name for ps5 to be consistent
06d6631
@bergmeister
re-trigger
9c4445b
@bergmeister
add badge
dfe241a
Christoph Bergmeister
multi stage build-test
58df168
@bergmeister Christoph Bergmeister (bergmeister) added the Area - Build label Feb 3, 2020
Christoph Bergmeister added 8 commits February 3, 2020 07:30
Christoph Bergmeister
bootstrap pester
b4ef261
Christoph Bergmeister
Cleanup and avoid Pester bootstrap in build stage
2623e58
Christoph Bergmeister
download pipeline artifact in test stage
c7bbb5f
Christoph Bergmeister
try fix artifact download path
270bb78
Christoph Bergmeister
try fix artifact path using '$(Build.SourcesDirectory)/out' and add d…
db7d529 
…ebugging info
Christoph Bergmeister
fix ps syntax
7a13f38
Christoph Bergmeister
remove debugging step
ca2c14c
Christoph Bergmeister
Fix suggestion text to have platform specific newlines and enable tes…
e4717dd 
…t on Linux
@bergmeister Christoph Bergmeister (bergmeister) changed the title WIP: Multi stage yaml WIP: Multi-stage pipelines (to split build->test) Feb 3, 2020
Christoph Bergmeister added 4 commits February 3, 2020 13:01
Christoph Bergmeister
add more windows images
4459f9e
Christoph Bergmeister
try use strategy
c34fb1a
Christoph Bergmeister
try
164bca3
Christoph Bergmeister
fix job name
329f712
Christoph Bergmeister added 3 commits February 3, 2020 15:09
Christoph Bergmeister
rename and try to not use a job name
f5edd4e
Christoph Bergmeister
remove pwsh variable, which is now redundant as it is now in test.yaml
5c8bb36
Christoph Bergmeister
remove old comment
06309b8
@bergmeister Christoph Bergmeister (bergmeister) changed the title WIP: Multi-stage pipelines (to split build->test) Multi-stage pipelines (to split build->test) Feb 3, 2020
@bergmeister Christoph Bergmeister (bergmeister) changed the title Multi-stage pipelines (to split build->test) WIP Multi-stage pipelines (to split build->test) Feb 3, 2020
Christoph Bergmeister added 3 commits February 3, 2020 17:05
Christoph Bergmeister
try fix tests on wmf4
6ff0c07
Christoph Bergmeister
try use -be instead of -match operator
bb95ab4
Christoph Bergmeister
fix wmf4 test failure due to CRLF not being correctly used in this ve…
8eaf6fd 
…rsion
@bergmeister Christoph Bergmeister (bergmeister) changed the title WIP Multi-stage pipelines (to split build->test) Multi-stage pipelines (to split build->test) Feb 3, 2020
@bergmeister
Christoph Bergmeister (bergmeister) marked this pull request as ready for review February 3, 2020 23:16
Christoph Bergmeister
Merge branch 'master' of https://github.com/powershell/psscriptanalyzer…
20e5b1b 
… into multi-stage-yaml

# Conflicts:
#	.azure-pipelines-ci/ci.yaml
#	.azure-pipelines-ci/templates/unix.yaml
@bergmeister
Christoph Bergmeister (bergmeister) requested review from James Truher (JamesWTruher) and Rob Holt (rjmholt) February 3, 2020 23:20
rjmholt
Rob Holt (rjmholt) approved these changes Feb 4, 2020
View reviewed changes
Comment thread .azure-pipelines-ci/ci.yaml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Christoph Bergmeister
make pscompatiblitycollector build against all frameworks again
9f81fab
@bergmeister
Christoph Bergmeister (bergmeister) merged commit 1305c88 into PowerShell:master Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesWTruher James Truher (JamesWTruher) Awaiting requested review from JamesWTruher
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

Area - Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@bergmeister @rjmholt
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.